[oe-commits] Ross Burton : insane: handle recursive configures when checking for unknown configure options

git at git.openembedded.org git at git.openembedded.org
Mon Dec 16 12:12:02 UTC 2013


Module: openembedded-core.git
Branch: master
Commit: b226ab4cf7779f4dfaa78210cb6249766ed564c1
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=b226ab4cf7779f4dfaa78210cb6249766ed564c1

Author: Ross Burton <ross.burton at intel.com>
Date:   Tue Dec 10 19:38:26 2013 +0000

insane: handle recursive configures when checking for unknown configure options

Some recipes have configure scripts that recursively call other configure
scripts (e.g. dropbear).  These multiple-line matches were not being handled
correctly, so iterate over every matching line instead of assuming only one line
was found.

[ YOCTO #5646 ]

Signed-off-by: Ross Burton <ross.burton at intel.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/classes/insane.bbclass | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index a51f504..e77e993 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -941,8 +941,10 @@ Missing inherit gettext?""" % (gt, config))
         try:
             flag = "WARNING: unrecognized options:"
             log = os.path.join(d.getVar('B', True), 'config.log')
-            output = subprocess.check_output(['grep', '-F', flag, log])
-            options = set(map(lambda s: s.strip(' ,'), output.partition(flag)[2].split()))
+            output = subprocess.check_output(['grep', '-F', flag, log]).replace(', ', ' ')
+            options = set()
+            for line in output.splitlines():
+                options |= set(line.partition(flag)[2].split())
             whitelist = set(d.getVar("UNKNOWN_CONFIGURE_WHITELIST", True).split())
             options -= whitelist
             if options:



More information about the Openembedded-commits mailing list