[oe-commits] Khem Raj : systemd.bbclass: Dont use libdir and base_libdir for units
git at git.openembedded.org
git at git.openembedded.org
Fri Feb 15 12:19:07 UTC 2013
Module: openembedded-core.git
Branch: master
Commit: 22e16f44b58ae6bbf719b9074d39aac065a402f1
URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=22e16f44b58ae6bbf719b9074d39aac065a402f1
Author: Khem Raj <raj.khem at gmail.com>
Date: Thu Feb 14 04:02:00 2013 +0000
systemd.bbclass: Dont use libdir and base_libdir for units
systemd always uses /lib and /usr/lib to store unit files
so using libdir and base_libdir is incorrect. It will work
where libdir is usr/lib and base_libdir is /lib but wont work
when say its /lib64
Add a check to make sure that SYSTEMD_PACKAGES are part of PACKAGES
too, otherwise error out
Signed-off-by: Khem Raj <raj.khem at gmail.com>
Signed-off-by: Saul Wold <sgw at linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
meta/classes/systemd.bbclass | 13 +++++++++----
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/meta/classes/systemd.bbclass b/meta/classes/systemd.bbclass
index 8b55813..00865ed 100644
--- a/meta/classes/systemd.bbclass
+++ b/meta/classes/systemd.bbclass
@@ -49,6 +49,12 @@ python systemd_populate_packages() {
val = (d.getVar(var, True) or "").strip()
return val
+ # Check if systemd-packages already included in PACKAGES
+ def systemd_check_package(pkg_systemd):
+ packages = d.getVar('PACKAGES', True)
+ if not pkg_systemd in packages.split():
+ bb.error('%s does not appear in package list, please add it', " " + pkg_systemd)
+
# Add a runtime dependency on systemd to pkg
def systemd_add_rdepends(pkg):
@@ -118,11 +124,9 @@ python systemd_populate_packages() {
# Check service-files and call systemd_add_files_and_parse for each entry
def systemd_check_services():
- base_libdir = d.getVar('base_libdir', True)
searchpaths = [oe.path.join(d.getVar("sysconfdir", True), "systemd", "system"),]
- searchpaths.append(oe.path.join(d.getVar("base_libdir", True), "systemd", "system"))
- searchpaths.append(oe.path.join(d.getVar("libdir", True), "systemd", "system"))
- searchpaths.append(oe.path.join(d.getVar("libdir", True), "systemd", "user"))
+ searchpaths.append(oe.path.join(d.getVar("nonarch_base_libdir", True), "systemd", "system"))
+ searchpaths.append(oe.path.join(d.getVar("exec_prefix", True), d.getVar("nonarch_base_libdir", True), "systemd", "system"))
systemd_packages = d.getVar('SYSTEMD_PACKAGES', True)
has_exactly_one_service = len(systemd_packages.split()) == 1
if has_exactly_one_service:
@@ -149,6 +153,7 @@ python systemd_populate_packages() {
# Run all modifications once when creating package
if os.path.exists(d.getVar("D", True)):
for pkg in d.getVar('SYSTEMD_PACKAGES', True).split():
+ systemd_check_package(pkg)
if d.getVar('SYSTEMD_SERVICE_' + pkg, True):
systemd_generate_package_scripts(pkg)
systemd_add_rdepends(pkg)
More information about the Openembedded-commits
mailing list