[oe-commits] Robert P. J. Day : package.bbclass: Skip testing "packages" a second time.

git at git.openembedded.org git at git.openembedded.org
Mon Jan 7 11:36:24 UTC 2013


Module: openembedded-core.git
Branch: master
Commit: 371fbacff47828cfff99f1152f9e269e27c474da
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=371fbacff47828cfff99f1152f9e269e27c474da

Author: Robert P. J. Day <rpjday at crashcourse.ca>
Date:   Thu Jan  3 11:01:07 2013 -0500

package.bbclass: Skip testing "packages" a second time.

Since the "packages" variable is already tested a few lines above in
the same routine:

    if len(packages) < 1:
        bb.debug(1, "No packages to build, skipping do_package")
        return

there is no point testing it again, and the error message doesn't even
refer to "packages", anyway.

Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>
Signed-off-by: Saul Wold <sgw at linux.intel.com>

---

 meta/classes/package.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 34bbc46..b06cca5 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1885,7 +1885,7 @@ python do_package () {
     dvar = d.getVar('PKGD', True)
     pn = d.getVar('PN', True)
 
-    if not workdir or not outdir or not dest or not dvar or not pn or not packages:
+    if not workdir or not outdir or not dest or not dvar or not pn:
         bb.error("WORKDIR, DEPLOY_DIR, D, PN and PKGD all must be defined, unable to package")
         return
 





More information about the Openembedded-commits mailing list