[oe-commits] Richard Purdie : package.bbclass: Check FILES once, not once per loop iteration
git at git.openembedded.org
git at git.openembedded.org
Wed Jan 30 14:01:00 UTC 2013
Module: openembedded-core.git
Branch: master-next
Commit: 7e0e3ec1d580926bac6d4ed70deb31325316067a
URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=7e0e3ec1d580926bac6d4ed70deb31325316067a
Author: Richard Purdie <richard.purdie at linuxfoundation.org>
Date: Tue Jan 29 13:49:56 2013 +0000
package.bbclass: Check FILES once, not once per loop iteration
There is no need to check FILES in each loop iteration, we can just check it once
at the start when we read the variable.
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
meta/classes/package.bbclass | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 8b256cf..51ab009 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -961,12 +961,12 @@ python populate_packages () {
bb.data.update_data(localdata)
filesvar = localdata.getVar('FILES', True) or ""
+ if "//" in filesvar:
+ bb.warn("FILES variable for package %s contains '//' which is invalid. Attempting to fix this but you should correct the metadata.\n" % pkg)
+ filesvar.replace("//", "/")
files = filesvar.split()
file_links = {}
for file in files:
- if file.find("//") != -1:
- bb.warn("FILES variable for package %s contains '//' which is invalid. Attempting to fix this but you should correct the metadata.\n" % pkg)
- file.replace("//", "/")
if os.path.isabs(file):
file = '.' + file
if not os.path.islink(file):
More information about the Openembedded-commits
mailing list