[oe-commits] Zhenhua Luo : binutils: fix compile error of complex expressions before @l/ @h
git at git.openembedded.org
git at git.openembedded.org
Tue Jun 4 10:38:22 UTC 2013
Module: openembedded-core.git
Branch: master-next
Commit: 9ba812ab1f613d28f9eb3192d2ff1a34dfce33e4
URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=9ba812ab1f613d28f9eb3192d2ff1a34dfce33e4
Author: Zhenhua Luo <zhenhua.luo at freescale.com>
Date: Mon Jun 3 12:23:03 2013 +0800
binutils: fix compile error of complex expressions before @l/@h
Back port two patches to fix the error of complex expressions before @l/@h.
Error sample:
test.s: Assembler messages:
test.s:1: Error: operand out of range (0xffffffffffff8000 is not between 0x0000000000000000 and 0x000000000000ffff)
Fix Bug 4524.
Signed-off-by: Zhenhua Luo <zhenhua.luo at freescale.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
meta/recipes-devtools/binutils/binutils-2.23.2.inc | 4 +-
...pc.c-PPC_VLE_SPLIT16A-Delete-unused-macro.patch | 122 ++++++++++++++++++++
...pc.c-md_apply_fix-Sign-extend-fieldval-un.patch | 85 ++++++++++++++
3 files changed, 210 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-devtools/binutils/binutils-2.23.2.inc b/meta/recipes-devtools/binutils/binutils-2.23.2.inc
index abec597..f5b5a99 100644
--- a/meta/recipes-devtools/binutils/binutils-2.23.2.inc
+++ b/meta/recipes-devtools/binutils/binutils-2.23.2.inc
@@ -1,4 +1,4 @@
-PR = "r3"
+PR = "r4"
LIC_FILES_CHKSUM="\
file://src-release;endline=17;md5=4830a9ef968f3b18dd5e9f2c00db2d35\
@@ -41,6 +41,8 @@ BACKPORT = "\
file://backport/binutils-fix-skip-whitespace-pr14887.patch \
file://backport/aarch64-crn.patch \
file://backport/aarch64-movi.patch \
+ file://backport/0001-config-tc-ppc.c-PPC_VLE_SPLIT16A-Delete-unused-macro.patch \
+ file://backport/0002-config-tc-ppc.c-md_apply_fix-Sign-extend-fieldval-un.patch \
"
SRC_URI[md5sum] = "4f8fa651e35ef262edc01d60fb45702e"
SRC_URI[sha256sum] = "fe914e56fed7a9ec2eb45274b1f2e14b0d8b4f41906a5194eac6883cfe5c1097"
diff --git a/meta/recipes-devtools/binutils/binutils-2.23.2/backport/0001-config-tc-ppc.c-PPC_VLE_SPLIT16A-Delete-unused-macro.patch b/meta/recipes-devtools/binutils/binutils-2.23.2/backport/0001-config-tc-ppc.c-PPC_VLE_SPLIT16A-Delete-unused-macro.patch
new file mode 100644
index 0000000..6057ad5
--- /dev/null
+++ b/meta/recipes-devtools/binutils/binutils-2.23.2/backport/0001-config-tc-ppc.c-PPC_VLE_SPLIT16A-Delete-unused-macro.patch
@@ -0,0 +1,122 @@
+config/tc-ppc.c (PPC_VLE_SPLIT16A): Delete unused macro.
+ (PPC_VLE_SPLIT16D, PPC_VLE_LO16A, PPC_VLE_LO16D):
+ Likewise. (PPC_VLE_HI16A, PPC_VLE_HI16D):
+ Likewise. (PPC_VLE_HA16A, PPC_VLE_HA16D):
+ Likewise. (md_apply_fix):
+ Set fx_no_overflow for assorted relocations.
+ Shift and sign-extend fieldval for use by some VLE reloc
+ operand->insert functions.
+
+Upstream-Status: Backport
+
+Signed-off-by: Zhenhua Luo <zhenhua.luo at freescale.com>
+
+commit ee75ce72fd7a4b2dc47db46acc36905da8904be4
+Author: Alan Modra <amodra at bigpond.net.au>
+Date: Mon May 6 23:36:48 2013 +0000
+
+--- binutils-2.23.2/gas/config/tc-ppc.c.orig 2013-06-02 21:44:34.000000000 -0500
++++ binutils-2.23.2/gas/config/tc-ppc.c 2013-06-02 21:51:37.000000000 -0500
+@@ -64,40 +64,14 @@
+ /* #lo(value) denotes the least significant 16 bits of the indicated. */
+ #define PPC_LO(v) ((v) & 0xffff)
+
+-/* Split the indicated value with the msbs in bits 11-15
+- and the lsbs in bits 21-31. */
+-#define PPC_VLE_SPLIT16A(v) ((v & 0xf800) << 11) | (v & 0x7ff)
+-
+-/* Split the indicated value with the msbs in bits 6-10
+- and the lsbs in bits 21-31. */
+-#define PPC_VLE_SPLIT16D(v) ((v & 0xf800) << 5) | (v & 0x7ff)
+-
+-/* #lo(value) denotes the lsb 16 bits in split16a format. */
+-#define PPC_VLE_LO16A(v) PPC_VLE_SPLIT16A(PPC_LO(v))
+-
+-/* #lo(value) denotes the lsb 16 bits in split16d format. */
+-#define PPC_VLE_LO16D(v) PPC_VLE_SPLIT16D(PPC_LO(v))
+-
+ /* #hi(value) denotes bits 16 through 31 of the indicated value. */
+ #define PPC_HI(v) (((v) >> 16) & 0xffff)
+
+-/* #lo(value) denotes the msb 16 bits in split16a format. */
+-#define PPC_VLE_HI16A(v) PPC_VLE_SPLIT16A(PPC_HI(v))
+-
+-/* #lo(value) denotes the msb 16 bits in split16d format. */
+-#define PPC_VLE_HI16D(v) PPC_VLE_SPLIT16D(PPC_HI(v))
+-
+ /* #ha(value) denotes the high adjusted value: bits 16 through 31 of
+ the indicated value, compensating for #lo() being treated as a
+ signed number. */
+ #define PPC_HA(v) PPC_HI ((v) + 0x8000)
+
+-/* #ha(value) denotes the high adjusted value in split16a format. */
+-#define PPC_VLE_HA16A(v) PPC_VLE_SPLIT16A(PPC_HA(v))
+-
+-/* #ha(value) denotes the high adjusted value in split16d format. */
+-#define PPC_VLE_HA16D(v) PPC_VLE_SPLIT16D(PPC_HA(v))
+-
+ /* #higher(value) denotes bits 32 through 47 of the indicated value. */
+ #define PPC_HIGHER(v) (((v) >> 16 >> 16) & 0xffff)
+
+@@ -6379,7 +6353,10 @@
+ fixP->fx_r_type = BFD_RELOC_LO16_PCREL;
+ /* fall through */
+ case BFD_RELOC_LO16_PCREL:
++ case BFD_RELOC_PPC_VLE_LO16A:
++ case BFD_RELOC_PPC_VLE_LO16D:
+ fieldval = SEX16 (value);
++ fixP->fx_no_overflow = 1;
+ break;
+
+ case BFD_RELOC_HI16:
+@@ -6387,7 +6364,10 @@
+ fixP->fx_r_type = BFD_RELOC_HI16_PCREL;
+ /* fall through */
+ case BFD_RELOC_HI16_PCREL:
++ case BFD_RELOC_PPC_VLE_HI16A:
++ case BFD_RELOC_PPC_VLE_HI16D:
+ fieldval = SEX16 (PPC_HI (value));
++ fixP->fx_no_overflow = 1;
+ break;
+
+ case BFD_RELOC_HI16_S:
+@@ -6395,7 +6375,10 @@
+ fixP->fx_r_type = BFD_RELOC_HI16_S_PCREL;
+ /* fall through */
+ case BFD_RELOC_HI16_S_PCREL:
++ case BFD_RELOC_PPC_VLE_HA16A:
++ case BFD_RELOC_PPC_VLE_HA16D:
+ fieldval = SEX16 (PPC_HA (value));
++ fixP->fx_no_overflow = 1;
+ break;
+
+ #ifdef OBJ_ELF
+@@ -6403,24 +6386,28 @@
+ if (fixP->fx_pcrel)
+ goto bad_pcrel;
+ fieldval = SEX16 (PPC_HIGHER (value));
++ fixP->fx_no_overflow = 1;
+ break;
+
+ case BFD_RELOC_PPC64_HIGHER_S:
+ if (fixP->fx_pcrel)
+ goto bad_pcrel;
+ fieldval = SEX16 (PPC_HIGHERA (value));
++ fixP->fx_no_overflow = 1;
+ break;
+
+ case BFD_RELOC_PPC64_HIGHEST:
+ if (fixP->fx_pcrel)
+ goto bad_pcrel;
+ fieldval = SEX16 (PPC_HIGHEST (value));
++ fixP->fx_no_overflow = 1;
+ break;
+
+ case BFD_RELOC_PPC64_HIGHEST_S:
+ if (fixP->fx_pcrel)
+ goto bad_pcrel;
+ fieldval = SEX16 (PPC_HIGHESTA (value));
++ fixP->fx_no_overflow = 1;
+ break;
+
+ /* The following relocs can't be calculated by the assembler.
diff --git a/meta/recipes-devtools/binutils/binutils-2.23.2/backport/0002-config-tc-ppc.c-md_apply_fix-Sign-extend-fieldval-un.patch b/meta/recipes-devtools/binutils/binutils-2.23.2/backport/0002-config-tc-ppc.c-md_apply_fix-Sign-extend-fieldval-un.patch
new file mode 100644
index 0000000..a62ca47
--- /dev/null
+++ b/meta/recipes-devtools/binutils/binutils-2.23.2/backport/0002-config-tc-ppc.c-md_apply_fix-Sign-extend-fieldval-un.patch
@@ -0,0 +1,85 @@
+config/tc-ppc.c (md_apply_fix): Sign extend fieldval under control of operand flag bits.
+
+Upstream-Status: Backport
+
+Signed-off-by: Zhenhua Luo <zhenhua.luo at freescale.com>
+
+commit cf5434698882f41ddfcc469488e8a68c674aae03
+Author: Alan Modra <amodra at bigpond.net.au>
+Date: Thu May 9 04:01:53 2013 +0000
+
+--- binutils-2.23.2/gas/config/tc-ppc.c.orig 2013-06-02 21:53:24.000000000 -0500
++++ binutils-2.23.2/gas/config/tc-ppc.c 2013-06-02 22:03:00.000000000 -0500
+@@ -6355,7 +6355,10 @@
+ case BFD_RELOC_LO16_PCREL:
+ case BFD_RELOC_PPC_VLE_LO16A:
+ case BFD_RELOC_PPC_VLE_LO16D:
+- fieldval = SEX16 (value);
++ fieldval = value & 0xffff;
++ sign_extend_16:
++ if ((operand->flags & PPC_OPERAND_SIGNED) != 0)
++ fieldval = (fieldval ^ 0x8000) - 0x8000;
+ fixP->fx_no_overflow = 1;
+ break;
+
+@@ -6366,9 +6369,8 @@
+ case BFD_RELOC_HI16_PCREL:
+ case BFD_RELOC_PPC_VLE_HI16A:
+ case BFD_RELOC_PPC_VLE_HI16D:
+- fieldval = SEX16 (PPC_HI (value));
+- fixP->fx_no_overflow = 1;
+- break;
++ fieldval = PPC_HI (value);
++ goto sign_extend_16;
+
+ case BFD_RELOC_HI16_S:
+ if (fixP->fx_pcrel)
+@@ -6377,38 +6379,33 @@
+ case BFD_RELOC_HI16_S_PCREL:
+ case BFD_RELOC_PPC_VLE_HA16A:
+ case BFD_RELOC_PPC_VLE_HA16D:
+- fieldval = SEX16 (PPC_HA (value));
+- fixP->fx_no_overflow = 1;
+- break;
++ fieldval = PPC_HA (value);
++ goto sign_extend_16;
+
+ #ifdef OBJ_ELF
+ case BFD_RELOC_PPC64_HIGHER:
+ if (fixP->fx_pcrel)
+ goto bad_pcrel;
+- fieldval = SEX16 (PPC_HIGHER (value));
+- fixP->fx_no_overflow = 1;
+- break;
++ fieldval = PPC_HIGHER (value);
++ goto sign_extend_16;
+
+ case BFD_RELOC_PPC64_HIGHER_S:
+ if (fixP->fx_pcrel)
+ goto bad_pcrel;
+- fieldval = SEX16 (PPC_HIGHERA (value));
+- fixP->fx_no_overflow = 1;
+- break;
++ fieldval = PPC_HIGHERA (value);
++ goto sign_extend_16;
+
+ case BFD_RELOC_PPC64_HIGHEST:
+ if (fixP->fx_pcrel)
+ goto bad_pcrel;
+- fieldval = SEX16 (PPC_HIGHEST (value));
+- fixP->fx_no_overflow = 1;
+- break;
++ fieldval = PPC_HIGHEST (value);
++ goto sign_extend_16;
+
+ case BFD_RELOC_PPC64_HIGHEST_S:
+ if (fixP->fx_pcrel)
+ goto bad_pcrel;
+- fieldval = SEX16 (PPC_HIGHESTA (value));
+- fixP->fx_no_overflow = 1;
+- break;
++ fieldval = PPC_HIGHESTA (value);
++ goto sign_extend_16;
+
+ /* The following relocs can't be calculated by the assembler.
+ Leave the field zero. */
More information about the Openembedded-commits
mailing list