[oe-commits] Richard Purdie : sanity.bbclass: Add check for @ character in build directory name

[ChenQi]

I got really strange errors on both ubuntu12.04 and fc18.

Error, you have an invalid character (@) in your COREBASE directory 
path. Please move the installation to a directory which doesn't include 
any @ characters.
ERROR: Execution of event handler 'check_sanity_eventhandler' failed

But in fact, my COREBASE is '/home/chenqi/poky'.

So I added a line for debugging.

      if oeroot.find('@') != -1:
+        status.addresult("oeroot_find_ at _status = %d \t oeroot = %s\n" % 
(oeroot.find('@'), oeroot))
          status.addresult("Error, you have an invalid character (@) in 
your COREBASE directory path. Please move the installation to a 
directory which doesn't include any @ characters.")

And here's the result.
     oeroot_find_ at _status = 2      oeroot = /home/chenqi/poky
Error, you have an invalid character (@) in your COREBASE directory 
path. Please move the installation to a directory which doesn't include 
any @ characters.

//Chen Qi

On 06/27/2013 04:58 PM, git at opal.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 008cb3c501c8313a0a1a0ebce2b0aa61239b548d
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=008cb3c501c8313a0a1a0ebce2b0aa61239b548d
>
> Author: Richard Purdie <richard.purdie at linuxfoundation.org>
> Date:   Tue Jun 25 18:08:01 2013 +0100
>
> sanity.bbclass: Add check for @ character in build directory name
>
> The @ character is not escaped properly in too many places within the system
> to easily support it so add the character to the list of blacklisted characters.
>
> Also tweak the other messages and ensure that all appropriate error messages
> are disabled in one go.
>
> [YOCTO #4772]
>
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
>
> ---
>
>   meta/classes/sanity.bbclass |   10 ++++++----
>   1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 622bb41..cf23982 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -589,10 +589,12 @@ def check_sanity_everybuild(status, d):
>               pass
>   
>       oeroot = d.getVar('COREBASE')
> -    if oeroot.find ('+') != -1:
> -        status.addresult("Error, you have an invalid character (+) in your COREBASE directory path. Please move the installation to a directory which doesn't include a +.")
> -    elif oeroot.find (' ') != -1:
> -        status.addresult("Error, you have a space in your COREBASE directory path. Please move the installation to a directory which doesn't include a space.")
> +    if oeroot.find('+') != -1:
> +        status.addresult("Error, you have an invalid character (+) in your COREBASE directory path. Please move the installation to a directory which doesn't include any + characters.")
> +    if oeroot.find('@') != -1:
> +        status.addresult("Error, you have an invalid character (@) in your COREBASE directory path. Please move the installation to a directory which doesn't include any @ characters.")
> +    if oeroot.find(' ') != -1:
> +        status.addresult("Error, you have a space in your COREBASE directory path. Please move the installation to a directory which doesn't include a space since autotools doesn't support this.")
>   
>       # Check that TMPDIR hasn't changed location since the last time we were run
>       tmpdir = d.getVar('TMPDIR', True)
>
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
>
>