[oe-commits] Richard Purdie : package: Ensure we iterate all the pool objects

[git at git.openembedded.org]

Module: openembedded-core.git
Branch: master
Commit: 89c8493d4d85044cd72af2756569d15e87cd5947
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=89c8493d4d85044cd72af2756569d15e87cd5947

Author: Richard Purdie <richard.purdie at linuxfoundation.org>
Date:   Thu May 30 12:28:05 2013 +0000

package: Ensure we iterate all the pool objects

There is the possibility that if we don't iterate through the multiprocessing
pool objects we might not catch return codes and this could lead to hung/zombie
processes either temproarily or on a wider scale. Adding this certainly doesn't
hurt anything and is better practise so we might as well do it.

Its not 100% clear if this fixes some issues or not.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/classes/package.bbclass |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index f25f567..8e6029a 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -906,7 +906,7 @@ python split_and_strip_files () {
         import multiprocessing
         nproc = multiprocessing.cpu_count()
         pool = bb.utils.multiprocessingpool(nproc)
-        processed = pool.imap(oe.package.runstrip, sfiles)
+        processed = list(pool.imap(oe.package.runstrip, sfiles))
         pool.close()
         pool.join()
 
@@ -1265,7 +1265,7 @@ python package_do_filedeps() {
     import multiprocessing
     nproc = multiprocessing.cpu_count()
     pool =  bb.utils.multiprocessingpool(nproc)
-    processed = pool.imap(oe.package.filedeprunner, pkglist)
+    processed = list(pool.imap(oe.package.filedeprunner, pkglist))
     pool.close()
     pool.join()