[oe-commits] Richard Purdie : class/lib: Fix up various file access methods

Thu May 9 21:24:03 UTC 2013

Module: openembedded-core.git
Branch: master
Commit: a43e0a8ecd0441131e929daf998c3cd454d9c8f3
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=a43e0a8ecd0441131e929daf998c3cd454d9c8f3

Author: Richard Purdie <richard.purdie at linuxfoundation.org>
Date:   Thu May  9 17:05:58 2013 +0100

class/lib: Fix up various file access methods

There are various bits of cruft that have built up around our file accesses. This patch
cleans some of them up, specifically:

 * Remove pointless "from __builtin__ import file"
 * Use open(), not file()
 * Wrap file usage in a with container to ensure files are closed
 * Add missing .close() calls in some cases

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/classes/imagetest-qemu.bbclass   |    1 +
 meta/classes/insane.bbclass           |   25 +++++++------
 meta/classes/libc-package.bbclass     |    6 ++--
 meta/classes/metadata_scm.bbclass     |   21 ++++++-----
 meta/classes/package.bbclass          |    7 ++--
 meta/classes/package_deb.bbclass      |    6 ++--
 meta/classes/package_ipk.bbclass      |    6 ++--
 meta/classes/package_rpm.bbclass      |    9 ++---
 meta/classes/sanity.bbclass           |   63 +++++++++++++++-----------------
 meta/lib/oe/packagedata.py            |    2 +-
 meta/lib/oe/utils.py                  |    6 ++-
 meta/recipes-core/busybox/busybox.inc |    1 +
 12 files changed, 79 insertions(+), 74 deletions(-)

Diff:   http://git.openembedded.org/?p=openembedded-core.git/?a=commitdiff;h=a43e0a8ecd0441131e929daf998c3cd454d9c8f3