[oe-commits] Tom Zanussi : wic: Make find_binary_path() more user-friendly

git at git.openembedded.org git at git.openembedded.org
Wed Oct 23 06:01:20 UTC 2013


Module: openembedded-core.git
Branch: master
Commit: 0d9eef0eaa267500e8eedab8b72ddf24eb0516db
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=0d9eef0eaa267500e8eedab8b72ddf24eb0516db

Author: Tom Zanussi <tom.zanussi at linux.intel.com>
Date:   Tue Oct 22 09:24:04 2013 -0500

wic: Make find_binary_path() more user-friendly

find_binary_path() is useful, but if the binary isn't found, it prints
a stacktrace and a less-than-useful message.  Users complain when they
get stacktraces for things they can act on, so remove the stacktrace
and tell the user what the problem is.

Signed-off-by: Tom Zanussi <tom.zanussi at linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 scripts/lib/mic/utils/fs_related.py |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/scripts/lib/mic/utils/fs_related.py b/scripts/lib/mic/utils/fs_related.py
index 6161735..dd420e8 100644
--- a/scripts/lib/mic/utils/fs_related.py
+++ b/scripts/lib/mic/utils/fs_related.py
@@ -57,7 +57,10 @@ def find_binary_path(binary):
         bin_path = "%s/%s" % (path, binary)
         if os.path.exists(bin_path):
             return bin_path
-    raise CreatorError("Command '%s' is not available." % binary)
+
+    print "External command '%s' not found, exiting." % binary
+    print "  (Please install '%s' on your host system)" % binary
+    sys.exit(1)
 
 def makedirs(dirname):
     """A version of os.makedirs() that doesn't throw an



More information about the Openembedded-commits mailing list