[oe-commits] Kai Kang : python-smartpm: fix option typo of command channel
git at git.openembedded.org
git at git.openembedded.org
Sat Aug 2 08:30:29 UTC 2014
Module: openembedded-core.git
Branch: master
Commit: 03266e89a67ec1373529fae32b2cedff21414ff5
URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=03266e89a67ec1373529fae32b2cedff21414ff5
Author: Kai Kang <kai.kang at windriver.com>
Date: Wed Jul 30 14:26:27 2014 +0800
python-smartpm: fix option typo of command channel
When run smart, it fails:
root at qemu1:~# smart channel --remove-all
error: No action specified for command 'channel'
If no default value of arg 'dest' is provided in method add_option() of
optparse.OptionParser, it replaces hyphen('-') in new added option with
underscore('_') as dest.
In function ensure_action() it checks action strings with options from
optparse.OptionParser. So it is 'remove_all' which need to be checked
rather than 'remove-all'.
Signed-off-by: Kai Kang <kai.kang at windriver.com>
Signed-off-by: Saul Wold <sgw at linux.intel.com>
---
.../python/python-smartpm/smart-improve-error-reporting.patch | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/python/python-smartpm/smart-improve-error-reporting.patch b/meta/recipes-devtools/python/python-smartpm/smart-improve-error-reporting.patch
index fece5b9..2ca0f6d 100644
--- a/meta/recipes-devtools/python/python-smartpm/smart-improve-error-reporting.patch
+++ b/meta/recipes-devtools/python/python-smartpm/smart-improve-error-reporting.patch
@@ -24,7 +24,7 @@ index aa76f91..63fbb35 100644
+ opts.check_args_of_option("edit", 0)
+ opts.check_args_of_option("enable", -1)
+ opts.check_args_of_option("disable", -1)
-+ opts.ensure_action("channel", ["add", "set", "remove", "remove-all",
++ opts.ensure_action("channel", ["add", "set", "remove", "remove_all",
+ "list", "show", "yaml", "enable", "disable"])
+ opts.check_remaining_args()
+
More information about the Openembedded-commits
mailing list