[oe-commits] Tom Zanussi : wic: Make exec_cmd() error out instead of warn

git at git.openembedded.org git at git.openembedded.org
Mon Aug 11 09:55:11 UTC 2014


Module: openembedded-core.git
Branch: master
Commit: a10bbd39eee29cc49d258bf08aaec279c3115c66
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=a10bbd39eee29cc49d258bf08aaec279c3115c66

Author: Tom Zanussi <tom.zanussi at linux.intel.com>
Date:   Thu Jul 31 13:55:24 2014 -0500

wic: Make exec_cmd() error out instead of warn

The reason exec_cmd() warns but doesn't error out (broken parted)
doesn't really make sense, since the parted invocations don't even use
exec_cmd().  It really should just fail since by not doing so it's
actually enabling invalid images in some cases.

Also, since the return code is now always zero, there's no point in
having a return code, so remove it.  This represents a change in the
API, so we also need to update all callers.

Signed-off-by: Tom Zanussi <tom.zanussi at linux.intel.com>

---

 .../lib/mic/kickstart/custom_commands/partition.py | 44 +++++++++++-----------
 scripts/lib/mic/plugins/source/bootimg-efi.py      |  8 ++--
 scripts/lib/mic/plugins/source/bootimg-pcbios.py   | 10 ++---
 scripts/lib/mic/utils/fs_related.py                |  2 +-
 scripts/lib/mic/utils/oe/misc.py                   | 33 +++++++++-------
 scripts/lib/mic/utils/partitionedfs.py             |  2 +-
 6 files changed, 53 insertions(+), 46 deletions(-)

Diff:   http://git.openembedded.org/?p=openembedded-core.git/?a=commitdiff;h=a10bbd39eee29cc49d258bf08aaec279c3115c66


More information about the Openembedded-commits mailing list