[oe-commits] Richard Tollerton : udev-cache: strip timestamps on extract

git at git.openembedded.org git at git.openembedded.org
Sat Aug 23 22:02:47 UTC 2014


Module: openembedded-core.git
Branch: master-next
Commit: b31f8f1f053cdfa9428e3f667c05e7e2c600061e
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=b31f8f1f053cdfa9428e3f667c05e7e2c600061e

Author: Richard Tollerton <rich.tollerton at ni.com>
Date:   Fri Aug 22 16:30:51 2014 -0500

udev-cache: strip timestamps on extract

Under normal udev operation, device nodes are obviously timestamped
based on the system time at current boot. However, when using
udev-cache, they are timestamped from a previous boot.

The existence of machines lacking RTCs makes this more than a cosmetic
issue: if the current time is set further on in the boot, so that the
system time is still 1970 by the time the cache is extracted, tar will
print a timestamp warning for every extracted file (potentially hundreds
of them).

To fix, use -m on extract.

If using busybox `tar`, this commit requires
CONFIG_FEATURE_TAR_NOPRESERVE_TIME=y.

Signed-off-by: Richard Tollerton <rich.tollerton at ni.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/recipes-core/udev/udev/init | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
index a442c74..7b1a676 100644
--- a/meta/recipes-core/udev/udev/init
+++ b/meta/recipes-core/udev/udev/init
@@ -69,7 +69,7 @@ case "$1" in
 		    readfiles /etc/udev/cache.data
 		    OLDDATA="$READDATA"
 		    if [ "$OLDDATA" = "$NEWDATA" ]; then
-                            (cd /; tar xf $DEVCACHE > /dev/null 2>&1)
+                            (cd /; tar xmf $DEVCACHE > /dev/null 2>&1)
                             not_first_boot=1
                             [ "$VERBOSE" != "no" ] && echo "udev: using cache file $DEVCACHE"
                             [ -e /dev/shm/udev.cache ] && rm -f /dev/shm/udev.cache



More information about the Openembedded-commits mailing list