[oe-commits] Jacob Kroon : cml1.bbclass: Fix return code handling in do_menuconfig()

[git at git.openembedded.org]

Module: openembedded-core.git
Branch: master-next
Commit: a2241a92fc48e4286de17b23124a9e2f0fd8185b
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=a2241a92fc48e4286de17b23124a9e2f0fd8185b

Author: Jacob Kroon <jacob.kroon at mikrodidakt.se>
Date:   Mon Jan 27 22:00:21 2014 +0100

cml1.bbclass: Fix return code handling in do_menuconfig()

On my system, doing "bitbake -c menuconfig busybox" pops up
a gnome-terminal, I can see that the compilation starts but then the
terminal automatically exits.

It turns out I don't have ncurses development package installed on my host,
and OE's host sysroot isn't being passed to gcc, so compilation fails.
The window automatically closes before I can read the error message
since the '$' in the return code check needs to be escaped.

Make sure the user can read the error message by properly checking the
return code.

Signed-off-by: Jacob Kroon <jacob.kroon at mikrodidakt.se>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/classes/cml1.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index bb95639..e292ecb 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -21,7 +21,7 @@ python do_menuconfig() {
     except OSError:
         mtime = 0
 
-    oe_terminal("${SHELL} -c \"make menuconfig; if [ $? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
+    oe_terminal("${SHELL} -c \"make menuconfig; if [ \$? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
 
     # FIXME this check can be removed when the minimum bitbake version has been bumped
     if hasattr(bb.build, 'write_taint'):