[oe-commits] Richard Purdie : ptest: d.keys() is slow, use a list instead
git at git.openembedded.org
git at git.openembedded.org
Tue Jan 14 17:00:16 UTC 2014
Module: openembedded-core.git
Branch: master
Commit: 5901189f0442cefc4d17623547f7358ffc2d37a6
URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=5901189f0442cefc4d17623547f7358ffc2d37a6
Author: Richard Purdie <richard.purdie at linuxfoundation.org>
Date: Tue Jan 14 11:43:14 2014 +0000
ptest: d.keys() is slow, use a list instead
Unfortunately d.keys is extremely slow. Using a list in this case should be
fine since the addtask lines are immediately above the code and aren't
going to change often.
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
meta/classes/ptest.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/ptest.bbclass b/meta/classes/ptest.bbclass
index e5bbb89..caf7101 100644
--- a/meta/classes/ptest.bbclass
+++ b/meta/classes/ptest.bbclass
@@ -55,6 +55,6 @@ python () {
# Remove all '*ptest_base' tasks when ptest is not enabled
if not(d.getVar('PTEST_ENABLED', True) == "1"):
- for i in filter(lambda k: d.getVarFlag(k, "task") and k.endswith("ptest_base"), d.keys()):
+ for i in ['do_configure_ptest_base', 'do_compile_ptest_base', 'do_install_ptest_base']:
bb.build.deltask(i, d)
}
More information about the Openembedded-commits
mailing list