[oe-commits] Tom Zanussi : wic: Error on parted non-zero error code

git at git.openembedded.org git at git.openembedded.org
Wed Jul 16 09:32:00 UTC 2014


Module: openembedded-core.git
Branch: master-next
Commit: b1c68e5446080f0743f7f8a530f3b00f90c8717d
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=b1c68e5446080f0743f7f8a530f3b00f90c8717d

Author: Tom Zanussi <tom.zanussi at linux.intel.com>
Date:   Thu Jul 10 13:25:14 2014 -0500

wic: Error on parted non-zero error code

The current code uses msger.debug() to note errors, effectively
squelching them if --debug isn't used.  Apparently this is because it
can return non-zero for some loop device failures.  We don't care
about loop devices, and not paying attention to the error code
actually results in invalid images, so error out on parted failures as
we should be.

Signed-off-by: Tom Zanussi <tom.zanussi at linux.intel.com>
Signed-off-by: Saul Wold <sgw at linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 scripts/lib/mic/utils/partitionedfs.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/mic/utils/partitionedfs.py b/scripts/lib/mic/utils/partitionedfs.py
index 6607466..593cf1f 100644
--- a/scripts/lib/mic/utils/partitionedfs.py
+++ b/scripts/lib/mic/utils/partitionedfs.py
@@ -272,7 +272,7 @@ class PartitionedMount(Mount):
             # parted always fails to reload part table with loop devices. This
             # prevents us from distinguishing real errors based on return
             # code.
-            msger.debug("WARNING: parted returned '%s' instead of 0" % rc)
+            msger.error("WARNING: parted returned '%s' instead of 0 (use --debug for details)" % rc)
 
     def __create_partition(self, device, parttype, fstype, start, size):
         """ Create a partition on an image described by the 'device' object. """



More information about the Openembedded-commits mailing list