[oe-commits] Robert Yang : e2fsprogs: debugfs: use the functions in misc/create_inode.c

git at git.openembedded.org git at git.openembedded.org
Fri Mar 7 14:39:57 UTC 2014


Module: openembedded-core.git
Branch: master-next
Commit: 460f577379ef2ecf42fb8b7f855c21400c276d4f
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=460f577379ef2ecf42fb8b7f855c21400c276d4f

Author: Robert Yang <liezhi.yang at windriver.com>
Date:   Fri Mar  7 01:59:31 2014 -0500

e2fsprogs: debugfs: use the functions in misc/create_inode.c

* Use the functions in misc/create_inode.c, and remove the duplicated
  code.

* The CREATE_INODE_DEPS in the debugfs/Makefile.in is used for recording
  create_inode.o's depends which is from misc/Makefile.in, we have to
  recompile create_inode.o because we need it to print more messages when
  it is used by debugfs, just like we recompile e2freefrag.o, but it seems
  that the e2freefrag.o's depends in debugfs/Makefile.in is incorrect, it
  would not rebuild when its depends (e.g.: lib/config.h) is changed,
  which would cause unexpected errors. Make duplicated code in
  debugfs/Makefile.in and misc/Makefile.in is not a good idea, maybe we'd
  better define CREATE_INODE_DEPS in the top Makefile, I'd like to send
  another patch and fix the e2freefrag if you are fine with it.

[YOCTO #4083]

Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
Reviewed-by: Darren Hart <dvhart at linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 ...-use-the-functions-in-misc-create_inode.c.patch | 496 +++++++++++++++++++++
 1 file changed, 496 insertions(+)

Diff:   http://git.openembedded.org/?p=openembedded-core.git/?a=commitdiff;h=460f577379ef2ecf42fb8b7f855c21400c276d4f


More information about the Openembedded-commits mailing list