[oe-commits] Richard Purdie : base.bbclass: Fix multilib PREFERRED_VERSION handling

git at git.openembedded.org git at git.openembedded.org
Thu May 8 12:19:14 UTC 2014


Module: openembedded-core.git
Branch: master-next
Commit: d2b18d7692229d4b87b38becf173b1f8b6e90025
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=d2b18d7692229d4b87b38becf173b1f8b6e90025

Author: Richard Purdie <richard.purdie at linuxfoundation.org>
Date:   Wed May  7 15:03:18 2014 +0100

base.bbclass: Fix multilib PREFERRED_VERSION handling

Now that gcc-cross, gcc-crosssdk and others have expanded variables in
their names, the code that previous just applied to cross-canadian needs
expanding to cover the other cases. Improve the conditional and also
fix a bug where the multilib prefix wasn't being added into the generated
versions.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/classes/base.bbclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 10cb84a..8a74d6e 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -157,15 +157,15 @@ def preferred_ml_updates(d):
     for v in versions:
         val = d.getVar(v, False)
         pkg = v.replace("PREFERRED_VERSION_", "")
-        if pkg.endswith(("-native", "-crosssdk")) or pkg.startswith(("nativesdk-", "virtual/nativesdk-")):
+        if pkg.endswith("-native") or "-crosssdk-" in pkg or pkg.startswith(("nativesdk-", "virtual/nativesdk-")):
             continue
-        if 'cross-canadian' in pkg:
+        if '-cross-' in pkg and '${' in pkg:
             for p in prefixes:
                 localdata = bb.data.createCopy(d)
                 override = ":virtclass-multilib-" + p
                 localdata.setVar("OVERRIDES", localdata.getVar("OVERRIDES", False) + override)
                 bb.data.update_data(localdata)
-                newname = localdata.expand(v)
+                newname = localdata.expand(v).replace("PREFERRED_VERSION_", "PREFERRED_VERSION_" + p + '-')
                 if newname != v:
                     newval = localdata.expand(val)
                     d.setVar(newname, newval)



More information about the Openembedded-commits mailing list