[oe-commits] Ross Burton : autoconf: don't disable the autoheader warnings

[git at git.openembedded.org]

Module: openembedded-core.git
Branch: master-next
Commit: f2c62d6aef1f72e6b029a9b094bde3dcf887c85b
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=f2c62d6aef1f72e6b029a9b094bde3dcf887c85b

Author: Ross Burton <ross.burton at intel.com>
Date:   Wed May 28 12:56:26 2014 +0100

autoconf: don't disable the autoheader warnings

The usual autoheader warning is due to AC_DEFINE variables not having a
description.  This results in no variable being defined in config.h, which leads
to code behaving as if the test failed when it actually succeeded.

This patch was introduced to OpenEmbedded back in 2004:

http://git.openembedded.org/openembedded/commit/?id=5eab06d132cb2895fd579f5cedffbb54c27794f8

There is no rationale for the patch so I suspect this is due to the warnings
being fatal and the submitter not understanding that the problem is more than
cosmetic.

Signed-off-by: Ross Burton <ross.burton at intel.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 .../autoconf/autoconf/autoheader-nonfatal-warnings.patch  | 15 ---------------
 meta/recipes-devtools/autoconf/autoconf_2.69.bb           |  1 -
 2 files changed, 16 deletions(-)

diff --git a/meta/recipes-devtools/autoconf/autoconf/autoheader-nonfatal-warnings.patch b/meta/recipes-devtools/autoconf/autoconf/autoheader-nonfatal-warnings.patch
deleted file mode 100644
index 8ae6d5c..0000000
--- a/meta/recipes-devtools/autoconf/autoconf/autoheader-nonfatal-warnings.patch
+++ /dev/null
@@ -1,15 +0,0 @@
-Upstream-Status: Pending
-
---- autoconf-2.59/bin/autoheader.in~	2003-10-10 14:52:56.000000000 +0100
-+++ autoconf-2.59/bin/autoheader.in	2004-05-03 01:36:45.000000000 +0100
-@@ -272,8 +272,8 @@
- 	}
- 
-     }
--  exit 1
--    if keys %symbol;
-+#  exit 1
-+#    if keys %symbol;
- }
- 
- update_file ("$tmp/config.hin", "$config_h_in");
diff --git a/meta/recipes-devtools/autoconf/autoconf_2.69.bb b/meta/recipes-devtools/autoconf/autoconf_2.69.bb
index a2ecd94..5c652d4 100644
--- a/meta/recipes-devtools/autoconf/autoconf_2.69.bb
+++ b/meta/recipes-devtools/autoconf/autoconf_2.69.bb
@@ -12,7 +12,6 @@ SRC_URI += "file://autoreconf-include.patch \
 	    file://autoreconf-exclude.patch \
 	    file://autoreconf-foreign.patch \
 	    file://autoreconf-gnuconfigize.patch \
-	    file://autoheader-nonfatal-warnings.patch \
             file://config_site.patch \
             file://remove-usr-local-lib-from-m4.patch \
             file://preferbash.patch \