[oe-commits] Richard Purdie : lib/oe/package: Improve strip subprocess handling

[git at git.openembedded.org]

Module: openembedded-core.git
Branch: master-next
Commit: 0099f3960215aa49b410be55e9108bf00f9b80a3
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=0099f3960215aa49b410be55e9108bf00f9b80a3

Author: Richard Purdie <richard.purdie at linuxfoundation.org>
Date:   Tue Apr 28 17:09:58 2015 +0100

lib/oe/package: Improve strip subprocess handling

Currently if the strip process fails, we get a message but don't know why. This adds
code to show the return value and any error output.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/lib/oe/package.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
index 8bc56c6..947a977 100644
--- a/meta/lib/oe/package.py
+++ b/meta/lib/oe/package.py
@@ -34,14 +34,14 @@ def runstrip(arg):
     stripcmd = "'%s' %s '%s' -o '%s.tmp' && chown --reference='%s' '%s.tmp' && mv '%s.tmp' '%s'" % (strip, extraflags, file, file, file, file, file, file)
     bb.debug(1, "runstrip: %s" % stripcmd)
 
-    ret = subprocess.call(stripcmd, shell=True)
+    try:
+        output = subprocess.check_output(stripcmd, stderr=subprocess.STDOUT, shell=True)
+    except subprocess.CalledProcessError as e:
+        bb.error("runstrip: '%s' strip command failed with %s (%s)" % (stripcmd, e.returncode, e.output))
 
     if newmode:
         os.chmod(file, origmode)
 
-    if ret:
-        bb.error("runstrip: '%s' strip command failed" % stripcmd)
-
     return