[oe-commits] Costin Constantin : oeqa/prservice: add useful failure messages to test cases

git at git.openembedded.org git at git.openembedded.org
Thu Jul 23 07:49:45 UTC 2015


Module: openembedded-core.git
Branch: master
Commit: 5089154d1edc31cb208cf13189ee117ca0b445f3
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=5089154d1edc31cb208cf13189ee117ca0b445f3

Author: Costin Constantin <costin.c.constantin at intel.com>
Date:   Thu Jul 16 16:22:28 2015 +0300

oeqa/prservice: add useful failure messages to test cases

Signed-off-by: Costin Constantin <costin.c.constantin at intel.com>
Signed-off-by: Ross Burton <ross.burton at intel.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/lib/oeqa/selftest/prservice.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/lib/oeqa/selftest/prservice.py b/meta/lib/oeqa/selftest/prservice.py
index fb6d68d..4187fbf 100644
--- a/meta/lib/oeqa/selftest/prservice.py
+++ b/meta/lib/oeqa/selftest/prservice.py
@@ -17,7 +17,7 @@ class BitbakePrTests(oeSelfTest):
         package_data_file = os.path.join(pkgdata_dir, 'runtime', package_name)
         package_data = ftools.read_file(package_data_file)
         find_pr = re.search("PKGR: r[0-9]+\.([0-9]+)", package_data)
-        self.assertTrue(find_pr)
+        self.assertTrue(find_pr, "No PKG revision found in %s" % package_data_file)
         return int(find_pr.group(1))
 
     def get_task_stamp(self, package_name, recipe_task):
@@ -60,8 +60,8 @@ class BitbakePrTests(oeSelfTest):
         stamp_2 = self.get_task_stamp(package_name, track_task)
 
         bitbake("-ccleansstate %s" % package_name)
-        self.assertTrue(pr_2 - pr_1 == 1)
-        self.assertTrue(stamp_1 != stamp_2)
+        self.assertTrue(pr_2 - pr_1 == 1, "Step between same pkg. revision is greater than 1")
+        self.assertTrue(stamp_1 != stamp_2, "Different pkg rev. but same stamp: %s" % stamp_1)
 
     def run_test_pr_export_import(self, package_name, replace_current_db=True):
         self.config_pr_tests(package_name)
@@ -86,7 +86,7 @@ class BitbakePrTests(oeSelfTest):
         pr_2 = self.get_pr_version(package_name)
 
         bitbake("-ccleansstate %s" % package_name)
-        self.assertTrue(pr_2 - pr_1 == 1)
+        self.assertTrue(pr_2 - pr_1 == 1, "Step between same pkg. revision is greater than 1")
 
     @testcase(930)
     def test_import_export_replace_db(self):



More information about the Openembedded-commits mailing list