[oe-commits] Paul Eggleton : classes/buildstats: don't catch all errors from mkdirhier
git at git.openembedded.org
git at git.openembedded.org
Wed May 6 21:26:13 UTC 2015
Module: openembedded-core.git
Branch: master-next
Commit: acee8e166ca329decd08936beb43e1baaf18850e
URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=acee8e166ca329decd08936beb43e1baaf18850e
Author: Paul Eggleton <paul.eggleton at linux.intel.com>
Date: Wed May 6 17:19:26 2015 +0100
classes/buildstats: don't catch all errors from mkdirhier
mkdirhier() doesn't raise an exception if the directory exists, so if it
does raise one we should just be failing, otherwise we're just going
to hit errors later anyway.
Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
meta/classes/buildstats.bbclass | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/meta/classes/buildstats.bbclass b/meta/classes/buildstats.bbclass
index f15c45d..54d9f72 100644
--- a/meta/classes/buildstats.bbclass
+++ b/meta/classes/buildstats.bbclass
@@ -181,20 +181,14 @@ python run_buildstats () {
# at first pass make the buildstats heriarchy and then
# set the buildname
########################################################################
- try:
- bb.utils.mkdirhier(e.data.getVar('BUILDSTATS_BASE', True))
- except:
- pass
+ bb.utils.mkdirhier(e.data.getVar('BUILDSTATS_BASE', True))
set_bn(e)
bn = get_bn(e)
set_device(e)
device = get_device(e)
bsdir = os.path.join(e.data.getVar('BUILDSTATS_BASE', True), bn)
- try:
- bb.utils.mkdirhier(bsdir)
- except:
- pass
+ bb.utils.mkdirhier(bsdir)
if device != "NoLogicalDevice":
set_diskdata("__diskdata_build", device, e.data)
set_timedata("__timedata_build", e.data)
@@ -242,10 +236,7 @@ python run_buildstats () {
if device != "NoLogicalDevice":
set_diskdata("__diskdata_task", device, e.data)
set_timedata("__timedata_task", e.data, e.time)
- try:
- bb.utils.mkdirhier(taskdir)
- except:
- pass
+ bb.utils.mkdirhier(taskdir)
# write into the task event file the name and start time
file = open(os.path.join(taskdir, e.task), "a")
file.write("Event: %s \n" % bb.event.getName(e))
More information about the Openembedded-commits
mailing list