[oe-commits] Shiqun Lin : sanity.bbclass: improve the sanity check for PATH and BBPATH
git at git.openembedded.org
git at git.openembedded.org
Tue May 19 11:05:01 UTC 2015
Module: openembedded-core.git
Branch: master-next
Commit: 0a83128349f49a74b6d74f7159504ff248e0155b
URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=0a83128349f49a74b6d74f7159504ff248e0155b
Author: Shiqun Lin <Shiqun.Lin at windriver.com>
Date: Wed Jan 7 15:00:31 2015 +0800
sanity.bbclass: improve the sanity check for PATH and BBPATH
Build fails if "./" is in the PATH
To reproduce the issue:
$ export PATH="./:$PATH"
$ make -C build-tools elfutils
Error: ./ld: unrecognized option '--sysroot=/'
Signed-off-by: Shiqun Lin <Shiqun.Lin at windriver.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
meta/classes/sanity.bbclass | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index fc8c980..e738110 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -653,9 +653,9 @@ def check_sanity_version_change(status, d):
status.addresult("You have a 32-bit libc, but no 32-bit headers. You must install the 32-bit libc headers.\n")
bbpaths = d.getVar('BBPATH', True).split(":")
- if ("." in bbpaths or "" in bbpaths) and not status.reparse:
+ if ("." in bbpaths or "./" in bbpaths or "" in bbpaths) and not status.reparse:
status.addresult("BBPATH references the current directory, either through " \
- "an empty entry, or a '.'.\n\t This is unsafe and means your "\
+ "an empty entry, a './' or a '.'.\n\t This is unsafe and means your "\
"layer configuration is adding empty elements to BBPATH.\n\t "\
"Please check your layer.conf files and other BBPATH " \
"settings to remove the current working directory " \
@@ -693,8 +693,8 @@ def check_sanity_everybuild(status, d):
sanity_check_conffiles(status, d)
paths = d.getVar('PATH', True).split(":")
- if "." in paths or "" in paths:
- status.addresult("PATH contains '.' or '' (empty element), which will break the build, please remove this.\nParsed PATH is " + str(paths) + "\n")
+ if "." in paths or "./" in paths or "" in paths:
+ status.addresult("PATH contains '.', './' or '' (empty element), which will break the build, please remove this.\nParsed PATH is " + str(paths) + "\n")
# Check that the DISTRO is valid, if set
# need to take into account DISTRO renaming DISTRO
More information about the Openembedded-commits
mailing list