[oe-commits] Peter Kjellerstedt : oe-git-proxy: Correct the parsing of a port in $ALL_PROXY

[git at git.openembedded.org]

Module: openembedded-core.git
Branch: master
Commit: 39eb19e2ae9add58c763b71b54bdb3739041b2d0
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=39eb19e2ae9add58c763b71b54bdb3739041b2d0

Author: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
Date:   Fri Sep 18 12:46:05 2015 +0200

oe-git-proxy: Correct the parsing of a port in $ALL_PROXY

Due to an error in the regular expression used to extract a port
number specified in $ALL_PROXY, rather than allowing the port number
to be followed by an optional "/", the port was required to be
followed by "/?".

This corrects the regular expression to allow an optional "/". It also
allows the odd "/?" suffix for backwards compatibility.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
Signed-off-by: Ross Burton <ross.burton at intel.com>

---

 scripts/oe-git-proxy | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/oe-git-proxy b/scripts/oe-git-proxy
index 2473282..b971c88 100755
--- a/scripts/oe-git-proxy
+++ b/scripts/oe-git-proxy
@@ -113,7 +113,9 @@ done
 # Proxy is necessary, determine protocol, server, and port
 PROTO=$(echo $ALL_PROXY | sed -e 's/\([^:]*\):\/\/.*/\1/')
 PROXY=$(echo $ALL_PROXY | sed -e 's/.*:\/\/\([^:]*\).*/\1/')
-PORT=$(echo $ALL_PROXY | sed -e 's/.*:\([0-9]*\)\/?$/\1/')
+# For backwards compatibility, this allows the port number to be followed by /?
+# in addition to the customary optional /
+PORT=$(echo $ALL_PROXY | sed -e 's/.*:\([0-9]*\)\(\/?\?\)\?$/\1/')
 if [ "$PORT" = "$ALL_PROXY" ]; then
 	PORT=""
 fi