[oe-commits] [bitbake] 38/45: toasterui: update build in internal state

[git at git.openembedded.org]

rpurdie pushed a commit to branch master
in repository bitbake.

commit d056cf40fc55530cb1736aedfb9a3c355884991e
Author: Ed Bartosh <ed.bartosh at linux.intel.com>
AuthorDate: Wed Apr 6 17:46:48 2016 +0100

    toasterui: update build in internal state
    
    buildinfohelper stores current Build object in its internal
    state. Any changes to Build object will be lost if internal
    state is not updated as current buildinfohelper code
    saves Build object from internal state when build is
    completed.
    
    This bug causes incorrect build state when build is cancelled.
    Updating internal state should fix it.
    
    Note, that this commit updates internal state after status of
    the build is changed to Build.CANCELLED. There are several other
    places in the code where Build object is updated without updating
    internal state. They should be carefully analyzed and fixed.
    
    Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
    Signed-off-by: Michael Wood <michael.g.wood at intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/ui/buildinfohelper.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/bb/ui/buildinfohelper.py b/lib/bb/ui/buildinfohelper.py
index 9cb2c54..1473a67 100644
--- a/lib/bb/ui/buildinfohelper.py
+++ b/lib/bb/ui/buildinfohelper.py
@@ -1420,6 +1420,7 @@ class BuildInfoHelper(object):
             logger.info("Build cancelled")
             br.build.outcome = Build.CANCELLED
             br.build.save()
+            self.internal_state['build'] = br.build
             errorcode = 0
 
         if errorcode == 0:

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.