[oe-commits] [openembedded-core] 08/31: image.bbclass: don't emit redundant IMAGE_CMD_xxx functions

git at git.openembedded.org git at git.openembedded.org
Fri Apr 29 06:55:17 UTC 2016


rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit 118c1ca4d8d62162e87caf287f96d90707ee5903
Author: Andre McCurdy <armccurdy at gmail.com>
AuthorDate: Thu Apr 14 20:47:46 2016 -0700

    image.bbclass: don't emit redundant IMAGE_CMD_xxx functions
    
    IMAGE_CMD_xxx commands are always inlined within do_image_xxx.
    
    When IMAGE_CMD_xxx is defined as a function (e.g. IMAGE_CMD_btrfs,
    IMAGE_CMD_cpio, etc), a redundant copy of the function will be emitted
    by default. Remove IMAGE_CMD_xxx 'func' flags to prevent that.
    
    Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/classes/image.bbclass | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 8bfd241..9ba6011 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -388,6 +388,10 @@ python () {
             bb.fatal("No IMAGE_CMD defined for IMAGE_FSTYPES entry '%s' - possibly invalid type name or missing support class" % t)
         cmds.append(localdata.expand("\tcd ${DEPLOY_DIR_IMAGE}"))
 
+        # Since a copy of IMAGE_CMD_xxx will be inlined within do_image_xxx,
+        # prevent a redundant copy of IMAGE_CMD_xxx being emitted as a function.
+        d.delVarFlag('IMAGE_CMD_' + realt, 'func')
+
         rm_tmp_images = set()
         def gen_conversion_cmds(bt):
             for ctype in ctypes:

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list