[oe-commits] [bitbake] 15/15: server/process: don't change UI process signal handler on terminate

[git at git.openembedded.org]

rpurdie pushed a commit to branch master-next
in repository bitbake.

commit 58c60a951229dcbd8253863fb24228d046c23f6e
Author: Paul Eggleton <paul.eggleton at linux.intel.com>
AuthorDate: Tue Dec 13 20:07:14 2016 +1300

    server/process: don't change UI process signal handler on terminate
    
    On terminating the connection to the server, we were disabling SIGINT -
    and this is executed on the UI side. I'm not sure whether the intention
    here was to undo the SIGINT disabling we did in the server, and it was
    just a mistake that it disabled rather than restored and it's run on the
    wrong side, or whether we wanted to stop the user from breaking out of
    the shutdown code - the commit message provides no clues either way.
    Regardless, we do not want to permanently disable Ctrl+C here - it's
    legitimate to terminate the connection to the server and then
    re-establish it within the same process; at least currently, devtool
    modify by virtue of using tinfoil in two separate parts of the code does
    this, and the result of this disabling is that during the second tinfoil
    usage we can potentially be parsing all recipes without the ability to
    easily interrupt the process.
    
    Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/server/process.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py
index 1654faf..1036366 100644
--- a/lib/bb/server/process.py
+++ b/lib/bb/server/process.py
@@ -224,7 +224,6 @@ class BitBakeProcessServerConnection(BitBakeBaseServerConnection):
                 if isinstance(event, logging.LogRecord):
                     logger.handle(event)
 
-        signal.signal(signal.SIGINT, signal.SIG_IGN)
         self.procserver.stop()
 
         while self.procserver.is_alive():

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.