[oe-commits] [openembedded-core] 33/116: devtool: upgrade: drop superfluous call to validate_pn

git at git.openembedded.org git at git.openembedded.org
Sun Feb 28 11:29:19 UTC 2016


rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit 12164c0ef7ef468500034faeb60838b6b4eae4e7
Author: Paul Eggleton <paul.eggleton at linux.intel.com>
AuthorDate: Mon Feb 22 11:56:08 2016 +1300

    devtool: upgrade: drop superfluous call to validate_pn
    
    The recipename argument to devtool upgrade specifies an existing recipe,
    so by definition the name will be valid (or it won't exist) - we don't
    need to validate it ourselves, that's only needed for situations like in
    devtool add where we're creating a new recipe.
    
    Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 scripts/lib/devtool/upgrade.py | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/scripts/lib/devtool/upgrade.py b/scripts/lib/devtool/upgrade.py
index a446c55..279a65f 100644
--- a/scripts/lib/devtool/upgrade.py
+++ b/scripts/lib/devtool/upgrade.py
@@ -297,12 +297,7 @@ def upgrade(args, config, basepath, workspace):
     if args.srcbranch and not args.srcrev:
         raise DevtoolError("If you specify --srcbranch/-B then you must use --srcrev/-S to specify the revision" % args.recipename)
 
-    reason = oe.recipeutils.validate_pn(args.recipename)
-    if reason:
-        raise DevtoolError(reason)
-
     tinfoil = setup_tinfoil(basepath=basepath, tracking=True)
-
     rd = parse_recipe(config, tinfoil, args.recipename, True)
     if not rd:
         return 1

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list