[oe-commits] [openembedded-core] 33/83: glib: disable valgrind support when compiling in mips16e mode

[git at git.openembedded.org]

rpurdie pushed a commit to branch master
in repository openembedded-core.

commit 50be6f861a6c1076ace0fdd3f4381706351987ba
Author: André Draszik <adraszik at tycoint.com>
AuthorDate: Fri Jun 24 11:58:30 2016 +0100

    glib: disable valgrind support when compiling in mips16e mode
    
    | mipsel-poky-linux-uclibc-gcc -mel -mabi=32 -msoft-float \
    |   -march=mips32r2 -mips16 -minterlink-compressed -mtune=24kec \
    |   -mdsp --sysroot=<sysroot> -DHAVE_CONFIG_H -I. \
    |   -I<glib>/glib -I.. -I.. -I../glib -I<glib>/glib -I<glib> \
    |   -DG_LOG_DOMAIN=\"GLib\" -DG_DISABLE_CAST_CHECKS -DGLIB_COMPILATION \
    |   -DPCRE_STATIC -pthread -Wall -Wstrict-prototypes \
    |   -Werror=declaration-after-statement -Werror=missing-prototypes \
    |   -Werror=implicit-function-declaration -Werror=pointer-arith \
    |   -Werror=init-self -Werror=format=2 -Werror=missing-include-dirs \
    |   -fvisibility=hidden -O2 -pipe -g -feliminate-unused-debug-types \
    |   -c <glib>/glib/gslice.c  -fPIC -DPIC -o .libs/libglib_2_0_la-gslice.o
    | {standard input}: Assembler messages:
    | {standard input}:2485: Error: invalid operands `move $11,$8'
    | {standard input}:2487: Error: invalid operands `srl $0,$0,13'
    | {standard input}:2488: Error: invalid operands `srl $0,$0,29'
    | {standard input}:2489: Error: invalid operands `srl $0,$0,3'
    | {standard input}:2490: Error: invalid operands `srl $0,$0,19'
    | {standard input}:2491: Error: invalid operands `or $13,$13,$13'
    | Makefile:2076: recipe for target 'libglib_2_0_la-gslice.lo' failed
    
    The alternative would probably be to force compilation in normal mips
    mode for all of glib (as is done for armv4 and armv5). While that
    would retain the valgrind support, valgrind support itself shouldn't
    be needed on the target device, and we rather keep the mips16e mode.
    
    Signed-off-by: André Draszik <adraszik at tycoint.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/recipes-core/glib-2.0/glib.inc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
index c2cceda..906e0d4 100644
--- a/meta/recipes-core/glib-2.0/glib.inc
+++ b/meta/recipes-core/glib-2.0/glib.inc
@@ -68,6 +68,9 @@ FILES_${PN}-utils = "${bindir}/*"
 
 ARM_INSTRUCTION_SET_armv4 = "arm"
 ARM_INSTRUCTION_SET_armv5 = "arm"
+# Valgrind runtime detection works using hand-written assembly, which
+# doesn't support mips16e
+CPPFLAGS_append_class-target_mips16e = " -DNVALGRIND=1"
 
 USE_NLS = "yes"
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.