[oe-commits] [openembedded-core] 37/122: gcc-cross: default linker hash style to sysv

[git at git.openembedded.org]

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit 707c81d82abe5f6aaa9e8cb50a3dc228a03b1bec
Author: Christopher Larson <chris_larson at mentor.com>
AuthorDate: Thu Jul 7 14:08:33 2016 -0700

    gcc-cross: default linker hash style to sysv
    
    We explicitly set the hash style to gnu in our LDFLAGS. Setting the default to
    this in the toolchain, while convenient, actually hides bugs, as a failure to
    obey LDFLAGS isn't noticed. By removing this, it's not dissimilar to how we
    poison the sysroot -- rather than relying on the default, notice right away if
    somoeone isn't obeying the needed flags.
    
    This will result in a failure to obey LDFLAGS causing a GNU_HASH QA failure,
    which is what's often seen with external toolchains. This brings us all on the
    same page, and makes sure a failure to obey LDFLAGS is seen early.
    
    This is limited to cross, to retain ease of use for SDKs.
    
    Signed-off-by: Christopher Larson <chris_larson at mentor.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/recipes-devtools/gcc/gcc-cross.inc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc b/meta/recipes-devtools/gcc/gcc-cross.inc
index f479360..c0b8751 100644
--- a/meta/recipes-devtools/gcc/gcc-cross.inc
+++ b/meta/recipes-devtools/gcc/gcc-cross.inc
@@ -13,6 +13,11 @@ PN = "gcc-cross-${TARGET_ARCH}"
 
 require gcc-configure-common.inc
 
+# While we want the 'gnu' hash style, we explicitly set it to sysv here to
+# ensure that any recipe which doesn't obey our LDFLAGS (which also set it to
+# gnu) will hit a QA failure.
+LINKER_HASH_STYLE ?= "sysv"
+
 EXTRA_OECONF += "--enable-poison-system-directories"
 EXTRA_OECONF_append_sh4 = " \
     --with-multilib-list= \

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.