[oe-commits] [openembedded-core] 34/60: lib/oe/gpg_sign: fix output in error paths

git at git.openembedded.org git at git.openembedded.org
Mon Jul 25 08:59:01 UTC 2016


rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit 69c4bbcc47f2d8ec97f896d27e4815f8f90341e8
Author: Ross Burton <ross.burton at intel.com>
AuthorDate: Thu Jul 21 15:59:40 2016 +0100

    lib/oe/gpg_sign: fix output in error paths
    
    oe.utils.getstatusoutput() is a wrapper for subprocess.getstatusoutput() which
    uses Universal Newlines, so the output is a str() not bytes().
    
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/lib/oe/gpg_sign.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta/lib/oe/gpg_sign.py b/meta/lib/oe/gpg_sign.py
index a8a478a..38eb0cb 100644
--- a/meta/lib/oe/gpg_sign.py
+++ b/meta/lib/oe/gpg_sign.py
@@ -24,7 +24,7 @@ class LocalSigner(object):
         status, output = oe.utils.getstatusoutput(cmd)
         if status:
             raise bb.build.FuncFailed('Failed to export gpg public key (%s): %s' %
-                                      (keyid, output.decode("utf-8")))
+                                      (keyid, output))
 
     def sign_rpms(self, files, keyid, passphrase):
         """Sign RPM files"""
@@ -39,7 +39,7 @@ class LocalSigner(object):
 
         status, output = oe.utils.getstatusoutput(cmd)
         if status:
-            raise bb.build.FuncFailed("Failed to sign RPM packages: %s" % output.decode("utf-8"))
+            raise bb.build.FuncFailed("Failed to sign RPM packages: %s" % output)
 
     def detach_sign(self, input_file, keyid, passphrase_file, passphrase=None, armor=True):
         """Create a detached signature of a file"""
@@ -113,4 +113,3 @@ def get_signer(d, backend):
         return LocalSigner(d)
     else:
         bb.fatal("Unsupported signing backend '%s'" % backend)
-

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list