[oe-commits] [openembedded-core] 41/72: insane: only check ${S} exists if we had sources to fetch

[git at git.openembedded.org]

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit 8cba511ab6ea557fab9f7838dfe1fc8284bbdd68
Author: Ross Burton <ross.burton at intel.com>
AuthorDate: Thu Jul 21 20:29:27 2016 +0100

    insane: only check ${S} exists if we had sources to fetch
    
    Only check that ${S} actually exists if there was something in ${SRC_URI} to
    fetch, the argument being that if SRC_URI is empty the the recipe won't be using
    ${S} at all.
    
    In general recipes that have no sources can remove the unpack task, but
    expecting all recipes to do this relatively advanced operation isn't realistic.
    
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/classes/insane.bbclass | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 98381c2..2cb8cc0 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -1256,10 +1256,9 @@ Missing inherit gettext?""" % (gt, config))
 }
 
 python do_qa_unpack() {
-    bb.note("Checking has ${S} been created")
-
+    src_uri = d.getVar('SRC_URI', True)
     s_dir = d.getVar('S', True)
-    if not os.path.exists(s_dir):
+    if src_uri and not os.path.exists(s_dir):
         bb.warn('%s: the directory %s (%s) pointed to by the S variable doesn\'t exist - please set S within the recipe to point to where the source has been unpacked to' % (d.getVar('PN', True), d.getVar('S', False), s_dir))
 }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.