[oe-commits] [openembedded-core] 42/82: sanity.bbclass: expand error messages for version checks

[git at git.openembedded.org]

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit 00b3e316cd37c7d9627a4eb1073cf0f37ef2b2d4
Author: Patrick Ohly <patrick.ohly at intel.com>
AuthorDate: Thu Mar 17 17:00:55 2016 +0100

    sanity.bbclass: expand error messages for version checks
    
    The ${WORKDIR} variable was not getting expanded (anymore?), leading to
    less helpful error messages like:
    
       Exception: NotImplementedError: Your version of bblayers.conf has the wrong LCONF_VERSION (has 7, expecting 8).
       Please compare your file against bblayers.conf.sample and merge any changes before continuing.
       "meld conf/bblayers.conf ${COREBASE}/meta*/conf/bblayers.conf.sample"
    
       is a good way to visualise the changes.
    
       ERROR: Execution of event handler 'check_sanity_eventhandler' failed
    
    After adding expansion, embedding ${LCONF_VERSION} and ${LAYER_CONF_VERSION}
    in the error message seems a bit more readable and consistent.
    
    Signed-off-by: Patrick Ohly <patrick.ohly at intel.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/classes/sanity.bbclass | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 4873e64..334e362 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -48,6 +48,7 @@ Matching the version numbers will remove this message.
 \"meld conf/local.conf ${COREBASE}/meta*/conf/local.conf.sample\" 
 
 is a good way to visualise the changes."
+    failmsg = d.expand(failmsg)
 
     raise NotImplementedError(failmsg)
 }
@@ -66,6 +67,7 @@ Matching the version numbers will remove this message.
 \"meld conf/site.conf ${COREBASE}/meta*/conf/site.conf.sample\" 
 
 is a good way to visualise the changes."
+    failmsg = d.expand(failmsg)
 
     raise NotImplementedError(failmsg)
 }
@@ -76,11 +78,12 @@ python oecore_update_bblayers() {
     current_lconf = int(d.getVar('LCONF_VERSION', True))
     lconf_version = int(d.getVar('LAYER_CONF_VERSION', True))
 
-    failmsg = """Your version of bblayers.conf has the wrong LCONF_VERSION (has %s, expecting %s).
+    failmsg = """Your version of bblayers.conf has the wrong LCONF_VERSION (has ${LCONF_VERSION}, expecting ${LAYER_CONF_VERSION}).
 Please compare your file against bblayers.conf.sample and merge any changes before continuing.
 "meld conf/bblayers.conf ${COREBASE}/meta*/conf/bblayers.conf.sample" 
 
-is a good way to visualise the changes.""" % (current_lconf, lconf_version)
+is a good way to visualise the changes."""
+    failmsg = d.expand(failmsg)
 
     if not current_lconf:
         raise NotImplementedError(failmsg)

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.