[oe-commits] [openembedded-core] 05/12: oe-publish-sdk: prevent specifying a directory for the SDK argument

git at git.openembedded.org git at git.openembedded.org
Thu Mar 31 12:18:56 UTC 2016


rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit ce71f5c2fb8a7b473988da30bbb9bec95e8a6f5e
Author: Paul Eggleton <paul.eggleton at linux.intel.com>
AuthorDate: Thu Mar 31 21:53:32 2016 +1300

    oe-publish-sdk: prevent specifying a directory for the SDK argument
    
    The SDK argument is expected to be an installer .sh file; if a directory
    is specified we can get an ugly failure later on; best to check up
    front.
    
    Fixes [YOCTO #9065].
    
    Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 scripts/oe-publish-sdk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/oe-publish-sdk b/scripts/oe-publish-sdk
index 2b6e9bc..992de19 100755
--- a/scripts/oe-publish-sdk
+++ b/scripts/oe-publish-sdk
@@ -50,7 +50,10 @@ def publish(args):
 
     # Ensure the SDK exists
     if not os.path.exists(target_sdk):
-        logger.error("%s doesn't exist" % target_sdk)
+        logger.error("Specified SDK %s doesn't exist" % target_sdk)
+        return -1
+    if os.path.isdir(target_sdk):
+        logger.error("%s is a directory - expected path to SDK installer file" % target_sdk)
         return -1
 
     if ':' in destination:

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list