[oe-commits] [openembedded-core] 06/07: gcc-cross{, -canadian}: remove --with-linker-hash-style

git at git.openembedded.org git at git.openembedded.org
Wed May 11 09:56:05 UTC 2016


rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit 5ac4dffd748304e37a17232f28c86a740756b433
Author: Christopher Larson <chris_larson at mentor.com>
AuthorDate: Mon May 2 13:09:25 2016 -0700

    gcc-cross{, -canadian}: remove --with-linker-hash-style
    
    We explicitly set the hash style to gnu in our LDFLAGS. Setting the default to
    this in the toolchain, while convenient, actually hides bugs, as a failure to
    obey LDFLAGS isn't noticed. By removing this, it's not dissimilar to how we
    poison the sysroot -- rather than relying on the default, notice right away if
    somoeone isn't obeying the needed flags.
    
    This will result in a failure to obey LDFLAGS causing a GNU_HASH QA failure,
    which is what's often seen with external toolchains. This brings us all on the
    same page, and makes sure a failure to obey LDFLAGS is seen early.
    
    Signed-off-by: Christopher Larson <chris_larson at mentor.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/recipes-devtools/gcc/gcc-4.9.inc | 1 -
 meta/recipes-devtools/gcc/gcc-5.3.inc | 1 -
 2 files changed, 2 deletions(-)

diff --git a/meta/recipes-devtools/gcc/gcc-4.9.inc b/meta/recipes-devtools/gcc/gcc-4.9.inc
index 208e092..bb50205 100644
--- a/meta/recipes-devtools/gcc/gcc-4.9.inc
+++ b/meta/recipes-devtools/gcc/gcc-4.9.inc
@@ -112,7 +112,6 @@ EXTRA_OECONF_BASE = "\
     --disable-bootstrap \
     --disable-libmudflap \
     --with-system-zlib \
-    --with-linker-hash-style=${LINKER_HASH_STYLE} \
     --enable-linker-build-id \
     --with-ppl=no \
     --with-cloog=no \
diff --git a/meta/recipes-devtools/gcc/gcc-5.3.inc b/meta/recipes-devtools/gcc/gcc-5.3.inc
index 118ddb9..ad56145 100644
--- a/meta/recipes-devtools/gcc/gcc-5.3.inc
+++ b/meta/recipes-devtools/gcc/gcc-5.3.inc
@@ -113,7 +113,6 @@ EXTRA_OECONF_BASE = "\
     --disable-bootstrap \
     --disable-libmudflap \
     --with-system-zlib \
-    --with-linker-hash-style=${LINKER_HASH_STYLE} \
     --enable-linker-build-id \
     --with-ppl=no \
     --with-cloog=no \

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list