[oe-commits] [bitbake] 03/04: bb.event: fix infinite loop on print_ui_queue
git at git.openembedded.org
git at git.openembedded.org
Tue Nov 8 23:48:13 UTC 2016
rpurdie pushed a commit to branch 1.30
in repository bitbake.
commit bb56a8957255999b9ffd1408d249cc5b715b5a3a
Author: Aníbal Limón <anibal.limon at linux.intel.com>
AuthorDate: Fri Oct 14 10:48:39 2016 -0500
bb.event: fix infinite loop on print_ui_queue
If bitbake ends before _uiready and bb.event.LogHandler was add
to the bitbake logger it causes an infinite loop when logging
something.
The scenario is print_ui_queue is called at exit and executes
the log handlers [2] one of them is bb.event.LogHandler this handler
appends the same entry to ui_queue causing the inifine loop [3].
In order to fix a new copy of the ui_queue list is created when iterate
ui_queue.
[YOCTO #10399]
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=10399#c0
[2] http://git.openembedded.org/bitbake/tree/lib/bb/event.py?id=41d9cd41d40b04746c82b4a940dca47df02514fc#n156
[3]
http://git.openembedded.org/bitbake/tree/lib/bb/event.py?id=41d9cd41d40b04746c82b4a940dca47df02514fc#n164
Signed-off-by: Aníbal Limón <anibal.limon at linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
lib/bb/event.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/bb/event.py b/lib/bb/event.py
index 4b133a7..e71a8f2 100644
--- a/lib/bb/event.py
+++ b/lib/bb/event.py
@@ -125,7 +125,7 @@ def print_ui_queue():
# First check to see if we have any proper messages
msgprint = False
- for event in ui_queue:
+ for event in ui_queue[:]:
if isinstance(event, logging.LogRecord):
if event.levelno > logging.DEBUG:
if event.levelno >= logging.WARNING:
@@ -139,7 +139,7 @@ def print_ui_queue():
# Nope, so just print all of the messages we have (including debug messages)
logger.addHandler(stdout)
- for event in ui_queue:
+ for event in ui_queue[:]:
if isinstance(event, logging.LogRecord):
logger.handle(event)
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the Openembedded-commits
mailing list