[oe-commits] [bitbake] 05/10: data_smart.py: don't reorder internal bitbake variables when calculating hash

[git at git.openembedded.org]

rpurdie pushed a commit to branch master
in repository bitbake.

commit 3511d464f3a9d8b4334cda384b35016de69ce49e
Author: Patrick Ohly <patrick.ohly at intel.com>
AuthorDate: Mon Nov 14 10:39:00 2016 +0100

    data_smart.py: don't reorder internal bitbake variables when calculating hash
    
    Commit 260ced745 added __BBTASKS, __BBANONFUNCS, __BBHANDLERS to the
    data that gets hashed, but only after reordering these lists. The
    intention probably was to make the hash deterministic, but that's
    unnecessary (the content of the variables should already be
    deterministic) and hides potential reasons that might require
    re-parsing.
    
    Signed-off-by: Patrick Ohly <patrick.ohly at intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/data_smart.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/bb/data_smart.py b/lib/bb/data_smart.py
index cd3853e..b7badb6 100644
--- a/lib/bb/data_smart.py
+++ b/lib/bb/data_smart.py
@@ -956,7 +956,6 @@ class DataSmart(MutableMapping):
 
         for key in ["__BBTASKS", "__BBANONFUNCS", "__BBHANDLERS"]:
             bb_list = d.getVar(key, False) or []
-            bb_list.sort()
             data.update({key:str(bb_list)})
 
             if key == "__BBANONFUNCS":

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.