[oe-commits] [openembedded-core] 12/17: Revert "gst-player: Disable visualizations"

[git at git.openembedded.org]

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit c0a22a8d3e5d44ae3fba14a52582d39cfc600318
Author: Jussi Kukkonen <jussi.kukkonen at intel.com>
AuthorDate: Tue Oct 4 10:17:28 2016 +0300

    Revert "gst-player: Disable visualizations"
    
    This reverts oe-core commit b79d1bf49b56a97216fb719ac19e4dd9022f15b4.
    
    Now that xf86-video-intel is upgraded, visualizations can be enabled
    by default.
    
    Signed-off-by: Jussi Kukkonen <jussi.kukkonen at intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 .../0001-Disable-visualizations-by-default.patch   | 36 ----------------------
 .../recipes-multimedia/gstreamer/gst-player_git.bb |  1 -
 2 files changed, 37 deletions(-)

diff --git a/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch b/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch
deleted file mode 100644
index dabdcea..0000000
--- a/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch
+++ /dev/null
@@ -1,36 +0,0 @@
-From 93e1838f8b8704e4d7d71965f61bee931377b080 Mon Sep 17 00:00:00 2001
-From: Jussi Kukkonen <jussi.kukkonen at intel.com>
-Date: Thu, 22 Sep 2016 19:26:40 +0300
-Subject: [PATCH] Disable visualizations by default
-
-As documented in [YOCTO #10041] visualizations trigger a bug in
-xvimagesink on some hardware, which prevents playback in the
-mediaplayer. Disable visualizations until the xv issue is solved
-to enable playback QA.
-
-Upstream-Status: Inappropriate [workaround]
-Signed-off-by: Jussi Kukkonen <jussi.kukkonen at intel.com>
-Signed-off-by: Maxin B. John <maxin.john at intel.com>
----
- gtk/gtk-play.c | 5 ++---
- 1 file changed, 2 insertions(+), 3 deletions(-)
-
-diff --git a/gtk/gtk-play.c b/gtk/gtk-play.c
-index 8ae0fea..322e599 100644
---- a/gtk/gtk-play.c
-+++ b/gtk/gtk-play.c
-@@ -1751,9 +1751,8 @@ gtk_play_constructor (GType type, guint n_construct_params,
-   g_signal_connect (self->player, "volume-changed",
-       G_CALLBACK (player_volume_changed_cb), self);
- 
--  /* enable visualization (by default playbin uses goom) */
--  /* if visualization is enabled then use the first element */
--  gst_player_set_visualization_enabled (self->player, TRUE);
-+  /* Disable visualization by default */
-+  gst_player_set_visualization_enabled (self->player, FALSE);
- 
-   g_signal_connect (G_OBJECT (self), "show", G_CALLBACK (show_cb), NULL);
- 
--- 
-2.4.0
-
diff --git a/meta/recipes-multimedia/gstreamer/gst-player_git.bb b/meta/recipes-multimedia/gstreamer/gst-player_git.bb
index 51f3544..2a4c9dc 100644
--- a/meta/recipes-multimedia/gstreamer/gst-player_git.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-player_git.bb
@@ -9,7 +9,6 @@ SRC_URI = "git://github.com/sdroege/gst-player.git \
            file://Fix-pause-play.patch;apply=0 \
            file://Add-error-signal-emission-for-missing-plugins.patch;apply=0 \
            file://0001-gtk-play-provide-similar-behaviour-for-quit-and-clos.patch \
-           file://0001-Disable-visualizations-by-default.patch \
            file://gst-player.desktop"
 
 SRCREV = "ea90e63c1064503f9ba5d59aa4ca604f13ca5def"

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.