[oe-commits] [openembedded-core] 19/25: classes/populate_sdk_ext: ensure we clean the right temporary TMPDIR path

[git at git.openembedded.org]

rpurdie pushed a commit to branch master
in repository openembedded-core.

commit 038d9db66e69c9de12eb8581acb28a8facd726b6
Author: Paul Eggleton <paul.eggleton at linux.intel.com>
AuthorDate: Wed Sep 14 17:09:51 2016 +1200

    classes/populate_sdk_ext: ensure we clean the right temporary TMPDIR path
    
    After we run the build system within the eSDK internally as part of the
    sstate filtering that happens during do_populate_sdk_ext, we need to
    ensure that the TMPDIR created during that process gets deleted. However
    we were using the TMPDIR path for the build producing the eSDK which may
    not be the same (since that value would typically be filtered out) thus
    if the user had set TMPDIR to something other than the default, the
    temporary TMPDIR would not be deleted which not only led to extraneous
    junk entering the SDK but also failures during install because the
    TMPDIR path was different. In order to fix this, force TMPDIR to a known
    value during the sstate filtering run so we know what to delete
    afterwards.
    
    Fixes [YOCTO #10210].
    
    Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/classes/populate_sdk_ext.bbclass | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
index 1a15d2a..5402988 100644
--- a/meta/classes/populate_sdk_ext.bbclass
+++ b/meta/classes/populate_sdk_ext.bbclass
@@ -88,8 +88,7 @@ SDK_TITLE_task-populate-sdk-ext = "${@d.getVar('DISTRO_NAME', True) or d.getVar(
 def clean_esdk_builddir(d, sdkbasepath):
     """Clean up traces of the fake build for create_filtered_tasklist()"""
     import shutil
-    cleanpaths = 'cache conf/sanity_info conf/templateconf.cfg'.split()
-    cleanpaths.append(os.path.basename(d.getVar('TMPDIR', True)))
+    cleanpaths = 'cache conf/sanity_info conf/templateconf.cfg tmp'.split()
     for pth in cleanpaths:
         fullpth = os.path.join(sdkbasepath, pth)
         if os.path.isdir(fullpth):
@@ -109,10 +108,12 @@ def create_filtered_tasklist(d, sdkbasepath, tasklistfile, conf_initpath):
     # Create a temporary build directory that we can pass to the env setup script
     shutil.copyfile(sdkbasepath + '/conf/local.conf', sdkbasepath + '/conf/local.conf.bak')
     try:
-        # Force the use of sstate from the build system
         with open(sdkbasepath + '/conf/local.conf', 'a') as f:
+            # Force the use of sstate from the build system
             f.write('\nSSTATE_DIR_forcevariable = "%s"\n' % d.getVar('SSTATE_DIR', True))
             f.write('SSTATE_MIRRORS_forcevariable = ""\n')
+            # Ensure TMPDIR is the default so that clean_esdk_builddir() can delete it
+            f.write('TMPDIR_forcevariable = "${TOPDIR}/tmp"\n')
             # Drop uninative if the build isn't using it (or else NATIVELSBSTRING will
             # be different and we won't be able to find our native sstate)
             if not bb.data.inherits_class('uninative', d):

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.