[oe-commits] [openembedded-core] 15/29: devtool: add: drop superfluous validation for recipe name

git at git.openembedded.org git at git.openembedded.org
Mon Sep 19 08:12:09 UTC 2016


rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit e010d9be3709cf3c607ffc03c3188abe4e1e9eb4
Author: Paul Eggleton <paul.eggleton at linux.intel.com>
AuthorDate: Mon Sep 19 08:08:13 2016 +1200

    devtool: add: drop superfluous validation for recipe name
    
    Now that recipeutils.validate_pn() properly validates characters used in
    the name, we can drop this bit checking for '/' since that's not
    permitted by validate_pn(). (The FIXME comment here - that I myself
    apparently wrote - is questionable since that function was clearly never
    intended to allow '/', perhaps I was misled because it was broken and
    did so).
    
    Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 scripts/lib/devtool/standard.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index abbc0cb..8319145 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -85,10 +85,6 @@ def add(args, config, basepath, workspace):
         if reason:
             raise DevtoolError(reason)
 
-        # FIXME this ought to be in validate_pn but we're using that in other contexts
-        if '/' in args.recipename:
-            raise DevtoolError('"/" is not a valid character in recipe names')
-
     if args.srctree:
         srctree = os.path.abspath(args.srctree)
         srctreeparent = None

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list