[oe-commits] [bitbake] 14/16: toaster: unlock BuildEnvirnoment when build is done

git at git.openembedded.org git at git.openembedded.org
Tue Sep 20 14:28:16 UTC 2016


rpurdie pushed a commit to branch master-next
in repository bitbake.

commit faa88272d656640c039572c5c8f3e6c56535b6f7
Author: Ed Bartosh <ed.bartosh at linux.intel.com>
AuthorDate: Fri Sep 16 17:22:35 2016 +0100

    toaster: unlock BuildEnvirnoment when build is done
    
    There is no need to lock build environment before changing
    build status as this operation is very fast. However, there
    is a need to unlock it after changing build status.
    
    Explicitly unlocked BuildEnvironment after build reaches
    final status SUCCEEDED, FAILED or CANCELLED. This should
    allow runbuilds process to pickup next build faster.
    
    Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
    Signed-off-by: Michael Wood <michael.g.wood at intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/ui/buildinfohelper.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/bb/ui/buildinfohelper.py b/lib/bb/ui/buildinfohelper.py
index c93ee94..2246960 100644
--- a/lib/bb/ui/buildinfohelper.py
+++ b/lib/bb/ui/buildinfohelper.py
@@ -1524,9 +1524,7 @@ class BuildInfoHelper(object):
             return
 
         br_id, be_id = self.brbe.split(":")
-        be = BuildEnvironment.objects.get(pk = be_id)
-        be.lock = BuildEnvironment.LOCK_LOCK
-        be.save()
+
         br = BuildRequest.objects.get(pk = br_id)
 
         # if we're 'done' because we got cancelled update the build outcome
@@ -1543,6 +1541,10 @@ class BuildInfoHelper(object):
         else:
             br.state = BuildRequest.REQ_FAILED
         br.save()
+
+        be = BuildEnvironment.objects.get(pk = be_id)
+        be.lock = BuildEnvironment.LOCK_FREE
+        be.save()
         signal_runbuilds()
 
     def store_log_error(self, text):

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list