[oe-commits] [openembedded-core] 05/12: x264: add textrel to INSANE_SKIP

[git at git.openembedded.org]

rpurdie pushed a commit to branch master
in repository openembedded-core.

commit 9470e0911838a6f5a23f01c6944906b69aa1317a
Author: Fahad Usman <fahad_usman at mentor.com>
AuthorDate: Wed Sep 21 15:12:43 2016 +0530

    x264: add textrel to INSANE_SKIP
    
    Tried by adding CFLAGS_append = " -fpic " to
    the recipe. But that couldn't help resolve the
    warning message:
    
    x264/r2491+gitAUTOINC+c8a773ebfc-r0/packages-split/x264/usr/lib/libx264.so.144' has relocations in .text [textrel]
    
    It was found that this warning is emitted because of the
    assembly files in the source code. And it is not easy to
    get rid of TEXTREL's which are coming from the assembly
    source files.
    
    Adding textrel to INSANE_SKIP resolves this issue.
    This issue was observed in cyclone5 and imx6qsabresd BSP's.
    So generalizing the patch.
    
    Signed-off-by: Fahad Usman <fahad_usman at mentor.com>
    Signed-off-by: Sujith Haridasan <Sujith_Haridasan at mentor.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/recipes-multimedia/x264/x264_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-multimedia/x264/x264_git.bb b/meta/recipes-multimedia/x264/x264_git.bb
index fa44f9c..393310f 100644
--- a/meta/recipes-multimedia/x264/x264_git.bb
+++ b/meta/recipes-multimedia/x264/x264_git.bb
@@ -48,6 +48,6 @@ do_install() {
     oe_runmake install DESTDIR=${D}
 }
 
-# PIC can't be enabled for 32-bit x86
-INSANE_SKIP_${PN}_append_x86 = " textrel"
+# PIC can't be enabled for few BSP's
+INSANE_SKIP_${PN}_append = " textrel"
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.