[oe-commits] [bitbake] 13/15: toaster: fix handling of EnvironmentError

git at git.openembedded.org git at git.openembedded.org
Wed Sep 28 14:05:08 UTC 2016


rpurdie pushed a commit to branch master-next
in repository bitbake.

commit c8f4ca008bf9396b0ed45d44bfe2220c82a614a9
Author: Ed Bartosh <ed.bartosh at linux.intel.com>
AuthorDate: Tue Sep 27 16:16:54 2016 +0100

    toaster: fix handling of EnvironmentError
    
    Due to the bug in processing EnvironmentError exception,
    toasterui ignores it. As EnvironmentError is a base for OSError
    and IOError this means that all OSError and IOError exceptions
    were silently ignored.
    
    Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
    Signed-off-by: Michael Wood <michael.g.wood at intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/ui/toasterui.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lib/bb/ui/toasterui.py b/lib/bb/ui/toasterui.py
index b5422cf..569957a 100644
--- a/lib/bb/ui/toasterui.py
+++ b/lib/bb/ui/toasterui.py
@@ -450,9 +450,12 @@ def main(server, eventHandler, params):
             return_value += 1
 
         except EnvironmentError as ioerror:
-            # ignore interrupted io
-            if ioerror.args[0] == 4:
-                pass
+            logger.warning("EnvironmentError: %s" % ioerror)
+            # ignore interrupted io system calls
+            if ioerror.args[0] == 4: # errno 4 is EINTR
+                logger.warning("Skipped EINTR: %s" % ioerror)
+            else:
+                raise
         except KeyboardInterrupt:
             if params.observe_only:
                 print("\nKeyboard Interrupt, exiting observer...")

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list