[oe-commits] [openembedded-core] 21/26: sstate.bbclass: check if mirror directory is writable

git at git.openembedded.org git at git.openembedded.org
Wed Apr 12 23:01:37 UTC 2017


This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit b8f26c011d5ed888d85fef040bd821400d54c8fe
Author: Ed Bartosh <ed.bartosh at linux.intel.com>
AuthorDate: Thu Apr 13 00:00:18 2017 +0300

    sstate.bbclass: check if mirror directory is writable
    
    Commit 51edde653707e7a3cd2186082458f01f32cd1996 makes a wrong assumption
    that SSTATE_MIRRORS have write permissions.
    
    A mirror is by definition outside of it's user control. In my use case
    it happens I does not have permissions to update the access time of the
    dereferenced symbolic-link file.
    
    Checked if file is writable before changing its atime.
    
    Thanks to Paulo Neves for the patch.
    
    [YOCTO #11307]
    
    Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/classes/sstate.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index bc0ec54..5b66c01 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -753,7 +753,7 @@ python sstate_sign_package () {
 sstate_unpack_package () {
 	tar -xvzf ${SSTATE_PKG}
 	# update .siginfo atime on local/NFS mirror
-	[ -h ${SSTATE_PKG}.siginfo ] && touch -a ${SSTATE_PKG}.siginfo
+	[ -w ${SSTATE_PKG}.siginfo ] && [ -h ${SSTATE_PKG}.siginfo ] && touch -a ${SSTATE_PKG}.siginfo
 	# Use "! -w ||" to return true for read only files
 	[ ! -w ${SSTATE_PKG} ] || touch --no-dereference ${SSTATE_PKG}
 	[ ! -w ${SSTATE_PKG}.sig ] || [ ! -e ${SSTATE_PKG}.sig ] || touch --no-dereference ${SSTATE_PKG}.sig

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list