[oe-commits] [openembedded-core] 22/40: run-postinsts: do not reload daemon configuration

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit 07b0c0dd6fbb1baff3a7eb2fd44cad4babb5d071
Author: Max Krummenacher <max.oss.09 at gmail.com>
AuthorDate: Sat Aug 12 19:20:59 2017 +0200

    run-postinsts: do not reload daemon configuration
    
    In case a systemd service disables itself while init is still in its
    boot sequence the reloading of the service files can be problematic.
    In that case: It seems that systemd looses the state of .device units,
    and some services depend on such units (namely serial consoles such as
    serial-getty at ttymxc0.service). As a result no getty is spawned on the
    affected serial tty.
    After a power-cycle the second boot (which does not disable services)
    succeeds.
    
    The following sequence shows this problem:
    
    | Jan 09 16:36:28 apalis-t30 systemctl[162]: Removed /etc/systemd/system/sysinit.target.wants/run-postinsts.service.
    | Jan 09 16:36:28 apalis-t30 systemd[1]: Reloading.
    |    ...
    |    And then the failing one:
    | Feb 22 15:33:15 apalis-t30 systemd[1]: dev-ttyS0.device: Job dev-ttyS0.device/start timed out.
    | Feb 22 15:33:15 apalis-t30 systemd[1]: Timed out waiting for device dev-ttyS0.device.
    | Feb 22 15:33:15 apalis-t30 systemd[1]: Dependency failed for Serial Getty on ttyS0.
    | Feb 22 15:33:15 apalis-t30 systemd[1]: serial-getty at ttyS0.service: Job serial-getty at ttyS0.service/start failed with result 'dependency'.
    | Feb 22 15:33:15 apalis-t30 systemd[1]: dev-ttyS0.device: Job dev-ttyS0.device/start failed with result 'timeout'.
    | Feb 22 15:33:15 apalis-t30 systemd[1]: Reached target Login Prompts.
    
    (the time has been updated between this two events, but that does not
    influence the issue)
    
    Using --no-reload in the service file avoids the "Reloading." message
    above and seems to not cause such issues anymore.
    
    Reported-by: Stefan Agner <stefan.agner at toradex.com>
    Signed-off-by: Max Krummenacher <max.krummenacher at toradex.com>
    (cherry picked from commit 4a425d05bac5dcba023b67aa3d726f7e7869404f)
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service
index 85a0439..1b71a1f 100644
--- a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service
+++ b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service
@@ -8,7 +8,7 @@ ConditionPathExistsGlob=#SYSCONFDIR#/*-postinsts
 [Service]
 Type=oneshot
 ExecStart=#SBINDIR#/run-postinsts
-ExecStartPost=#BASE_BINDIR#/systemctl disable run-postinsts.service
+ExecStartPost=#BASE_BINDIR#/systemctl --no-reload disable run-postinsts.service
 RemainAfterExit=No
 TimeoutSec=0
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.