[oe-commits] [bitbake] branch master-next updated: process: Ensure we call select() to know which fds to read

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository bitbake.

The following commit(s) were added to refs/heads/master-next by this push:
     new bbcce58  process: Ensure we call select() to know which fds to read
bbcce58 is described below

commit bbcce58e824b2793abf50efa52db158ae16e23e4
Author: Richard Purdie <richard.purdie at linuxfoundation.org>
AuthorDate: Mon Aug 21 21:26:52 2017 +0100

    process: Ensure we call select() to know which fds to read
    
    There is an interesting bug in the current code where a sync command
    is not seen until the current async command completes, by which time
    the UI may have shut down.
    
    The reason is that if there are idle commands, we may not end up sleeping
    in the select call at all, partiularly under heavy load like parsing.
    
    Fix this by calling select with a zero timeout so that we see active
    fds and know to read from them. This fixes various problems toaster was
    having with the recent server changes.
    
    [YOCTO #11898]
    
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/server/process.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py
index 2ebfdfc..3ab793c 100644
--- a/lib/bb/server/process.py
+++ b/lib/bb/server/process.py
@@ -312,7 +312,7 @@ class ProcessServer(multiprocessing.Process):
                 # Ignore EINTR
                 return []
         else:
-            return []
+            return select.select(fds,[],[],0)[0]
 
 
 class ServerCommunicator():

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.