[oe-commits] [bitbake] branch master-next updated: command: Fix some bugs identified by BB_SERVER_TIMEOUT

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository bitbake.

The following commit(s) were added to refs/heads/master-next by this push:
     new af3c892  command: Fix some bugs identified by BB_SERVER_TIMEOUT
af3c892 is described below

commit af3c8928a69f204d5ced02c947485990ac04a776
Author: Richard Purdie <richard.purdie at linuxfoundation.org>
AuthorDate: Wed Aug 30 13:38:42 2017 +0100

    command: Fix some bugs identified by BB_SERVER_TIMEOUT
    
    The 'needconfig' flag was meant to be the default as most commands do need
    it and the "False" cases were the exception. The code was written backwards
    with a default False value. Invert this to match the intent, resulting in
    the config being reparsed if metadata has changed.
    
    Also ensure the second level configuration is parsed for the getLayerPriorities
    command as otherwise it can return stale info.
    
    With these changes:
    
    BB_SERVER_TIMEOUT=100 oe-selftest -r bblayers.BitbakeLayers.test_bitbakelayers_add_remove
    
    passes instead of fails.
    
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/command.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/bb/command.py b/lib/bb/command.py
index a923245..0d0354c 100644
--- a/lib/bb/command.py
+++ b/lib/bb/command.py
@@ -79,7 +79,7 @@ class Command:
                     return None, "Not able to execute not readonly commands in readonly mode"
             try:
                 self.cooker.process_inotify_updates()
-                if getattr(command_method, 'needconfig', False):
+                if getattr(command_method, 'needconfig', True):
                     self.cooker.updateCacheSync()
                 result = command_method(self, commandline)
             except CommandError as exc:
@@ -283,6 +283,7 @@ class CommandsSync:
     parseConfiguration.needconfig = False
 
     def getLayerPriorities(self, command, params):
+        command.cooker.parseConfiguration()
         ret = []
         # regex objects cannot be marshalled by xmlrpc
         for collection, pattern, regex, pri in command.cooker.bbfile_config_priorities:

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.