[oe-commits] [openembedded-core] 03/122: rng-tools: Fix crazy defaults

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch rocko
in repository openembedded-core.

commit d177516d846ec4bed483d7e9d80775bb341c869e
Author: Richard Purdie <richard.purdie at linuxfoundation.org>
AuthorDate: Fri Nov 3 16:17:01 2017 +0000

    rng-tools: Fix crazy defaults
    
    Feeding the output of /dev/urandom into /dev/random is pretty much insane
    and not something we should encourage.
    
    I can't really imagine a scenario where this would be a sensible idea since
    /dev/urandom if effectively derived from /dev/random.
    
    This changes the tool to default to /dev/hwrng which makes much more sense,
    feeding hardware entropy into the random pool. In the QEMU case, this will
    feed entropy from the host into the guests which is also what we want.
    
    Yes, this change will cause rngd not to start if /dev/hwrng isn't present,
    but it isn't needed if that isn't so I don't see this as a bad thing.
    
    (https://wiki.archlinux.org/index.php/Rng-tools has a section in red which
    agrees with the above, "this is a really bad idea, since you are simple
    filling the kernel entropy pool with entropy coming from the kernel itself!")
    
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
    (cherry picked from commit f1dc9ac46710814c27cae2d22e79c84a9522993a)
    Signed-off-by: Armin Kuster <akuster808 at gmail.com>
---
 meta/recipes-support/rng-tools/rng-tools/default | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/recipes-support/rng-tools/rng-tools/default b/meta/recipes-support/rng-tools/rng-tools/default
index 7aede9b..ab7cd93 100644
--- a/meta/recipes-support/rng-tools/rng-tools/default
+++ b/meta/recipes-support/rng-tools/rng-tools/default
@@ -1,3 +1,2 @@
 # Specify rng device
-#RNG_DEVICE=/dev/hwrng
-RNG_DEVICE=/dev/urandom
+RNG_DEVICE=/dev/hwrng

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.