[oe-commits] [openembedded-core] 02/64: runqemu: check exit code of 'ls -t'

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master
in repository openembedded-core.

commit dac68d2323b0b630c019ce4d5256ed567eaf00da
Author: Ed Bartosh <ed.bartosh at linux.intel.com>
AuthorDate: Tue Jul 11 17:34:24 2017 +0300

    runqemu: check exit code of 'ls -t'
    
    Used check_output instead of Popen as it raises CalledProcessError
    exception when command exits with non-zero exit code.
    
    Catched the exception to produce user-friendly output.
    
    [YOCTO #11719]
    
    Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 scripts/runqemu | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index c33741d..d44afc7 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -676,7 +676,10 @@ class BaseConfig(object):
             else:
                 cmd = 'ls -t %s/*.qemuboot.conf' %  deploy_dir_image
                 logger.info('Running %s...' % cmd)
-                qbs = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE).stdout.read().decode('utf-8')
+                try:
+                    qbs = subprocess.check_output(cmd, shell=True).decode('utf-8')
+                except subprocess.CalledProcessError as err:
+                    raise RunQemuError(err)
                 if qbs:
                     for qb in qbs.split():
                         # Don't use initramfs when other choices unless fstype is ramfs

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.