[oe-commits] [openembedded-core] 02/02: oeqa/selftest: lock down Meson git revision for reliability

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch krogoth
in repository openembedded-core.

commit b7a26dbca4d92b36aeb8b183e679701b5706adb0
Author: Ross Burton <ross.burton at intel.com>
AuthorDate: Mon Jun 5 17:30:42 2017 +0100

    oeqa/selftest: lock down Meson git revision for reliability
    
    The test_recipetool_create_github test fetches HEAD of the repository so
    upstream changes can (and do) break the test.  Avoid these problems by passing
    the rev= argument in the URL to lock the checkout to the same version that is
    fetched in the github_tarball test.
    
    Also pass the commands to runCmd() as a list instead of a string, the semicolon
    in the URL needs more quotes if the shell is involved and passing a list
    bypasses the shell entirely.
    
    Signed-off-by: Ross Burton <ross.burton at intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/lib/oeqa/selftest/recipetool.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/lib/oeqa/selftest/recipetool.py b/meta/lib/oeqa/selftest/recipetool.py
index 5cae8a7..312684b 100644
--- a/meta/lib/oeqa/selftest/recipetool.py
+++ b/meta/lib/oeqa/selftest/recipetool.py
@@ -447,8 +447,8 @@ class RecipetoolTests(RecipetoolBase):
         temprecipe = os.path.join(self.tempdir, 'recipe')
         os.makedirs(temprecipe)
         recipefile = os.path.join(temprecipe, 'meson_git.bb')
-        srcuri = 'https://github.com/mesonbuild/meson'
-        result = runCmd('recipetool create -o %s %s' % (temprecipe, srcuri))
+        srcuri = 'https://github.com/mesonbuild/meson;rev=0.32.0'
+        result = runCmd(['recipetool', 'create', '-o', temprecipe, srcuri])
         self.assertTrue(os.path.isfile(recipefile))
         checkvars = {}
         checkvars['LICENSE'] = set(['Apache-2.0', 'Unknown'])

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.