[oe-commits] [openembedded-core] 65/91: buildstats.bbclass: Avoid index exception in /proc/PID/io parsing

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit b26feaf51af55f17fad79dbd53dd3ec0a37c38ff
Author: Pavel Modilaynen <pavelmn at axis.com>
AuthorDate: Fri Feb 24 11:22:20 2017 +0100

    buildstats.bbclass: Avoid index exception in /proc/PID/io parsing
    
    There is some probability (depends on system load) to get empty
    or line containing "0" as the last line while reading /proc/PID/io.
    Avoid build failure by checking if line contains separator
    ":" before split.
    
    Signed-off-by: Pavel Modilaynen <pavelmn at axis.com>
    Signed-off-by: Daniel Lublin <daniel at lublin.se>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/classes/buildstats.bbclass | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/classes/buildstats.bbclass b/meta/classes/buildstats.bbclass
index 8d7b598..960653c 100644
--- a/meta/classes/buildstats.bbclass
+++ b/meta/classes/buildstats.bbclass
@@ -31,6 +31,11 @@ def get_process_cputime(pid):
                 i = f.readline().strip()
                 if not i:
                     break
+                if not ":" in i:
+                    # one more extra line is appended (empty or containing "0")
+                    # most probably due to race condition in kernel while
+                    # updating IO stats
+                    break
                 i = i.split(": ")
                 iostats[i[0]] = i[1]
     resources = resource.getrusage(resource.RUSAGE_SELF)

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.